Fix RenderLayer::collectLayers logic bug.

Source/core/rendering/RenderLayer.h

 /*
  * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
  *
  * Portions are Copyright (C) 1998 Netscape Communications Corporation.
  *
  * Other contributors:
  *   Robert O'Callahan <roc+@cs.cmu.edu>
  *   David Baron <dbaron@fas.harvard.edu>
  *   Christian Biesinger <cbiesinger@web.de>
  *   Randall Jesup <rjesup@wgate.com>
@@ skipping 804 matching lines @@
     void computePaintOrderList(PaintOrderListType type, Vector<RefPtr<Node> >&);
 
     enum ForceNeedsCompositedScrollingMode {
         DoNotForceCompositedScrolling = 0,
         ForceCompositedScrollingOn,
         ForceCompositedScrollingOff
     };
     void setForceNeedsCompositedScrolling(ForceNeedsCompositedScrollingMode);
 
 private:
-    enum CollectLayersBehavior { StopAtStackingContexts, StopAtStackingContainers };
-
     void updateZOrderLists();
     void rebuildZOrderLists();
     // See the comment for collectLayers for information about the layerToForceAsStackingContainer parameter.
-    void rebuildZOrderLists(CollectLayersBehavior, OwnPtr<Vector<RenderLayer*> >&, OwnPtr<Vector<RenderLayer*> >&, const RenderLayer* layerToForceAsStackingContainer = 0);
+    void rebuildZOrderLists(OwnPtr<Vector<RenderLayer*> >&, OwnPtr<Vector<RenderLayer*> >&, const RenderLayer* layerToForceAsStackingContainer = 0, ForceNeedsCompositedScrollingMode = DoNotForceCompositedScrolling);

[shawnsingh, 2013/05/07 00:47:42]

I would feel more comfortable with an identifier name here, i.e.
"ForceNeedsCompositedScrollingMode mode = DoNotForceCompositedScrolling"
(mode could be replaced with a better name, too, perhaps)

Same for the other 2 instances of this default argument.

[hartmanng, 2013/05/13 19:27:06]

Apparently this is against the style, unless it "adds information". Naming this
"mode", "acceleratedCompositingForOverflowScrollEnabledMode", or anything
similar, prompts the following style error:

The parameter name "acceleratedCompositingForOverflowScrollEnabledMode" adds no
information, so it should be removed.  [readability/parameter_name] [5]


In this case I think the type name itself is fairly descriptive (also note that
Ian changed it in a patch this depends on, it's now called
"AcceleratedCompositingForOverflowScrollEnabledMode"). Do you have a name in
mind that would make it more clear?

     void clearZOrderLists();
 
     void updateNormalFlowList();
 
     bool isStackingContext(const RenderStyle* style) const { return !style->hasAutoZIndex() || isRootLayer(); }
 
     bool isDirtyStackingContainer() const { return m_zOrderListsDirty && isStackingContainer(); }
 
     void setAncestorChainHasSelfPaintingLayerDescendant();
     void dirtyAncestorChainHasSelfPaintingLayerDescendantStatus();
@@ skipping 58 matching lines @@
     void setParent(RenderLayer* parent);
     void setFirstChild(RenderLayer* first) { m_first = first; }
     void setLastChild(RenderLayer* last) { m_last = last; }
 
     LayoutPoint renderBoxLocation() const { return renderer()->isBox() ? toRenderBox(renderer())->location() : LayoutPoint(); }
 
     // layerToForceAsStackingContainer allows us to build pre-promotion and
     // post-promotion layer lists, by allowing us to treat a layer as if it is a
     // stacking context, without adding a new member to RenderLayer or modifying
     // the style (which could cause extra allocations).
-    void collectLayers(bool includeHiddenLayers, CollectLayersBehavior, OwnPtr<Vector<RenderLayer*> >&, OwnPtr<Vector<RenderLayer*> >&, const RenderLayer* layerToForceAsStackingContainer = 0);
+    void collectLayers(bool includeHiddenLayers, OwnPtr<Vector<RenderLayer*> >&, OwnPtr<Vector<RenderLayer*> >&, const RenderLayer* layerToForceAsStackingContainer = 0, ForceNeedsCompositedScrollingMode = DoNotForceCompositedScrolling);
 
     struct LayerPaintingInfo {
         LayerPaintingInfo(RenderLayer* inRootLayer, const LayoutRect& inDirtyRect, PaintBehavior inPaintBehavior, const LayoutSize& inSubPixelAccumulation, RenderObject* inPaintingRoot = 0, RenderRegion*inRegion = 0, OverlapTestRequestMap* inOverlapTestRequests = 0)
             : rootLayer(inRootLayer)
             , paintingRoot(inPaintingRoot)
             , paintDirtyRect(inDirtyRect)
             , subPixelAccumulation(inSubPixelAccumulation)
             , region(inRegion)
             , overlapTestRequests(inOverlapTestRequests)
             , paintBehavior(inPaintBehavior)
@@ skipping 62 matching lines @@
         const LayoutRect& hitTestRect, const HitTestLocation&, const HitTestingTransformState* = 0, double* zOffset = 0);
 
     bool listBackgroundIsKnownToBeOpaqueInRect(const Vector<RenderLayer*>*, const LayoutRect&) const;
 
     void computeScrollDimensions();
     bool hasHorizontalOverflow() const;
     bool hasVerticalOverflow() const;
     bool hasScrollableHorizontalOverflow() const;
     bool hasScrollableVerticalOverflow() const;
 
-    bool shouldBeNormalFlowOnly() const;
+    bool shouldBeNormalFlowOnly(ForceNeedsCompositedScrollingMode = DoNotForceCompositedScrolling) const;
 
     bool shouldBeSelfPaintingLayer() const;
 
     int scrollPosition(Scrollbar*) const;
     
     // ScrollableArea interface
     virtual void invalidateScrollbarRect(Scrollbar*, const IntRect&);
     virtual void invalidateScrollCornerRect(const IntRect&);
     virtual bool isActive() const;
     virtual bool isScrollCornerVisible() const;
@@ skipping 321 matching lines @@
 
 } // namespace WebCore
 
 #ifndef NDEBUG
 // Outside the WebCore namespace for ease of invocation from gdb.
 void showLayerTree(const WebCore::RenderLayer*);
 void showLayerTree(const WebCore::RenderObject*);
 #endif
 
 #endif // RenderLayer_h