Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1499873002:
Fix MotionEvent conversion unit test to use valid tilt angles. (Closed)
|
Created:
5 years ago by e_hakkinen Modified:
4 years, 6 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam Base URL:
https://chromium.googlesource.com/chromium/src@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix MotionEvent conversion unit test to use valid tilt angles.
Motion event tilt angles must be within a range from 0 to PI according to
http://developer.android.com/reference/android/view/MotionEvent.html#AXIS_TILT
BUG=514360
Committed: https://crrev.com/46ca814dfe298e5179e57e620e8104d42437ca06
Cr-Commit-Position: refs/heads/master@{#397501}
Patch Set 1 #
Messages
Total messages: 20 (9 generated)
Description was changed from ========== Fix MotionEvent conversion unit test to use valid tilt angles. BUG=514360 ========== to ========== Fix MotionEvent conversion unit test to use valid tilt angles. BUG=514360 ==========
eero.hakkinen@intel.com changed reviewers: + aelias@chromium.org
PTAL. Tilt angles must not be negative but positive. A stylus points straight to the left and is tilted (as always) to be opposite direction i.e. straight to the right thus tiltX is positive.
eero.hakkinen@intel.com changed reviewers: + mustaq@chromium.org
On 2015/12/04 10:24:08, e_hakkinen wrote: > PTAL. > > Tilt angles must not be negative but positive. > A stylus points straight to the left and is tilted (as always) to be opposite > direction i.e. straight to the right thus tiltX is positive. Yes, ME tilt must be positive, to make sure any 3D orientation of a stylus is represented by a unique (tilt,orientation) pair. Otherwise, a -ve tilt together with a 180-deg-off orientation would represent the same 3D orientation. LGTM but please add the spec link to the CL description: http://developer.android.com/reference/android/view/MotionEvent.html#AXIS_TILT
Description was changed from ========== Fix MotionEvent conversion unit test to use valid tilt angles. BUG=514360 ========== to ========== Fix MotionEvent conversion unit test to use valid tilt angles. Motion event tilt angles must be within a range from 0 to PI according to http://developer.android.com/reference/android/view/MotionEvent.html#AXIS_TILT BUG=514360 ==========
On 2015/12/15 20:28:27, mustaq wrote: > LGTM but please add the spec link to the CL description: Done.
On 2015/12/16 11:27:04, e_hakkinen wrote: > On 2015/12/15 20:28:27, mustaq wrote: > > LGTM but please add the spec link to the CL description: > > Done. Still LGTM.
The CQ bit was checked by eero.hakkinen@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499873002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
@aelias: PTAL
lgtm
The CQ bit was checked by eero.hakkinen@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499873002/1
Message was sent while issue was closed.
Description was changed from ========== Fix MotionEvent conversion unit test to use valid tilt angles. Motion event tilt angles must be within a range from 0 to PI according to http://developer.android.com/reference/android/view/MotionEvent.html#AXIS_TILT BUG=514360 ========== to ========== Fix MotionEvent conversion unit test to use valid tilt angles. Motion event tilt angles must be within a range from 0 to PI according to http://developer.android.com/reference/android/view/MotionEvent.html#AXIS_TILT BUG=514360 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix MotionEvent conversion unit test to use valid tilt angles. Motion event tilt angles must be within a range from 0 to PI according to http://developer.android.com/reference/android/view/MotionEvent.html#AXIS_TILT BUG=514360 ========== to ========== Fix MotionEvent conversion unit test to use valid tilt angles. Motion event tilt angles must be within a range from 0 to PI according to http://developer.android.com/reference/android/view/MotionEvent.html#AXIS_TILT BUG=514360 Committed: https://crrev.com/46ca814dfe298e5179e57e620e8104d42437ca06 Cr-Commit-Position: refs/heads/master@{#397501} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/46ca814dfe298e5179e57e620e8104d42437ca06 Cr-Commit-Position: refs/heads/master@{#397501} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
