Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Unified Diff: runtime/vm/native_message_handler.cc

Issue 1499853004: Adds a special case for sending an int over a port with the native API. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/native_message_handler.cc
diff --git a/runtime/vm/native_message_handler.cc b/runtime/vm/native_message_handler.cc
index 8f8d7a6971c725426060d8f1a5aa9aa6d4666a95..0e4002c5eebc80b86132dd0dcf554c0c6da88ad6 100644
--- a/runtime/vm/native_message_handler.cc
+++ b/runtime/vm/native_message_handler.cc
@@ -38,6 +38,7 @@ MessageHandler::MessageStatus NativeMessageHandler::HandleMessage(
// We currently do not use OOB messages for native ports.
UNREACHABLE();
}
+ ASSERT(message->len() > 0);
Ivan Posva 2015/12/09 22:45:28 You cannot assert this. The poster of the message
zra 2015/12/10 00:07:29 I'm not sure I see a good way to convert a RawObje
zra 2015/12/10 20:51:33 I've added some code to this CL to handle RawObjec
// We create a native scope for handling the message.
// All allocation of objects for decoding the message is done in the
// zone associated with this scope.

Powered by Google App Engine
This is Rietveld 408576698