runtime/vm/native_message_handler.cc - Issue 1499853004: Adds a special case for sending an int over a port with the native API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/native_message_handler.cc

Issue 1499853004: Adds a special case for sending an int over a port with the native API. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/native_message_handler.cc

diff --git a/runtime/vm/native_message_handler.cc b/runtime/vm/native_message_handler.cc

index 8f8d7a6971c725426060d8f1a5aa9aa6d4666a95..0e4002c5eebc80b86132dd0dcf554c0c6da88ad6 100644

--- a/runtime/vm/native_message_handler.cc

+++ b/runtime/vm/native_message_handler.cc

@@ -38,6 +38,7 @@ MessageHandler::MessageStatus NativeMessageHandler::HandleMessage(

// We currently do not use OOB messages for native ports.

UNREACHABLE();

}

+ ASSERT(message->len() > 0);

Ivan Posva 2015/12/09 22:35:29 You need to support receiving the RawObject* based

// We create a native scope for handling the message.

// All allocation of objects for decoding the message is done in the

// zone associated with this scope.

« runtime/vm/native_api_impl.cc ('K') | « runtime/vm/native_api_impl.cc ('k') | runtime/vm/port_test.cc » ('j') | no next file with comments »