Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: runtime/vm/message.cc

Issue 1499853004: Adds a special case for sending an int over a port with the native API. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/message.cc
diff --git a/runtime/vm/message.cc b/runtime/vm/message.cc
index 54f40b4eeb77c91cee4a35bbd2c5d356a0e75b48..f9a341909fef1fc87acc837f7ee9a4cb8305eefd 100644
--- a/runtime/vm/message.cc
+++ b/runtime/vm/message.cc
@@ -194,7 +194,12 @@ void MessageQueue::PrintJSON(JSONStream* stream) {
message.AddPropertyF("name", "Isolate Message (%" Px ")", current->Id());
message.AddPropertyF("messageObjectId", "messages/%" Px "",
current->Id());
- message.AddProperty("size", current->len());
+ if (current->type() == Message::kDataType) {
+ message.AddProperty("size", current->len());
+ } else {
+ ASSERT(current->type() == Message::kIntegerType);
+ message.AddProperty("integer", current->integer());
+ }
message.AddProperty("index", depth++);
message.AddPropertyF("_destinationPort", "%" Pd64 "",
static_cast<int64_t>(current->dest_port()));
« runtime/vm/message.h ('K') | « runtime/vm/message.h ('k') | runtime/vm/message_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698