Adds a special case for sending an int over a port with the native API.

runtime/vm/native_api_impl.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_native_api.h"
 
 #include "platform/assert.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_api_message.h"
 #include "vm/dart_api_state.h"
@@ skipping 38 matching lines @@
   bool success = writer.WriteCMessage(message);
 
   if (!success) return success;
 
   // Post the message at the given port.
   return PortMap::PostMessage(new Message(
       port_id, buffer, writer.BytesWritten(), Message::kNormalPriority));
 }
 
 
+DART_EXPORT bool Dart_PostInteger(Dart_Port port_id, intptr_t message) {
+  if (!Smi::IsValid(message)) {

[Ivan Posva, 2015/12/09 22:35:29]

How about not allowing failure here in the first place? Then failure is
equivalent to the other failures where posting failed and not because the value
is unexpectedly out of range.

DART_EXPORT bool Dart_PostInteger(Dart_Port port_id, int64_t value) {
  Message* msg;
  if (Smi::IsValid(value)) {
    msg = new Message(port_id, Smi::New(value), Message::kNormalPriority);
  } else {
    // Or use the Dart_CObject API here.
    const Integer& obj = Integer::Handle(Integer::New(value));
    MessageWriter writer(...);
    writer.WriteMessage(obj);
    msg = new Message(port_id, writer.data(), writer.BytesWritten(),
Message::kNormalPriority);
  }
  return PortMap::PostMessage(msg);
}

[zra, 2015/12/10 00:07:29]

Done.

+    return false;
+  }
+  Message* msg = new Message(
+      port_id, Smi::New(message), Message::kNormalPriority);
+
+  // Post the message at the given port.
+  return PortMap::PostMessage(msg);
+}
+
+
+DART_EXPORT bool Dart_PostSimpleObject(Dart_Port port_id, Dart_Handle message) {

[Ivan Posva, 2015/12/09 22:35:29]

Please remove. The short cutting here should be rolled into the regular
Dart_Post implementation.

[zra, 2015/12/10 00:07:29]

Done.

+  RawObject* raw_obj = Api::UnwrapHandle(message);
+  if (raw_obj->IsHeapObject() && !raw_obj->IsVMHeapObject()) {
+    return false;
+  }
+  Message* msg = new Message(port_id, raw_obj, Message::kNormalPriority);
+
+  // Post the message at the given port.
+  return PortMap::PostMessage(msg);
+}
+
+
 DART_EXPORT Dart_Port Dart_NewNativePort(const char* name,
                                          Dart_NativeMessageHandler handler,
                                          bool handle_concurrently) {
   if (name == NULL) {
     name = "<UnnamedNativePort>";
   }
   if (handler == NULL) {
     OS::PrintErr("%s expects argument 'handler' to be non-null.\n",
                  CURRENT_FUNC);
     return ILLEGAL_PORT;
@@ skipping 35 matching lines @@
   Dart_Handle result = Api::CheckAndFinalizePendingClasses(T);
   if (::Dart_IsError(result)) {
     return result;
   }
   CHECK_CALLBACK_STATE(T);
   CompileAll(T, &result);
   return result;
 }
 
 }  // namespace dart