Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1499853003: Remove C-Style casts in fwl_{barcode,caret,checkbox,combobox}imp.cpp (Closed)

Created:
5 years ago by Tom Sepez
Modified:
5 years ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Remove C-Style casts in fwl_{barcode,caret,checkbox,combobox}imp.cpp In the process, found two CFWL_ classes that didn't inherit from the virtual inteface they were allegedly supporting. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/59d09dfd276aa262d6fb95c4a78784fdc1824a26

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -103 lines) Patch
M xfa/src/fwl/src/basewidget/fwl_barcodeimp.cpp View 3 chunks +11 lines, -8 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_caretimp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_checkboximp.cpp View 5 chunks +10 lines, -8 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp View 41 chunks +82 lines, -67 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_caretimp.h View 2 chunks +6 lines, -3 lines 1 comment Download
M xfa/src/fwl/src/core/include/fwl_noteimp.h View 1 chunk +19 lines, -16 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
Lei, for review. https://codereview.chromium.org/1499853003/diff/20001/xfa/src/fwl/src/basewidget/include/fwl_caretimp.h File xfa/src/fwl/src/basewidget/include/fwl_caretimp.h (right): https://codereview.chromium.org/1499853003/diff/20001/xfa/src/fwl/src/basewidget/include/fwl_caretimp.h#newcode43 xfa/src/fwl/src/basewidget/include/fwl_caretimp.h:43: class CFWL_CaretTimer : public IFWL_Timer { ...
5 years ago (2015-12-04 23:38:48 UTC) #2
Lei Zhang
lgtm git cl lint will warn you about C-style casts, BTW.
5 years ago (2015-12-05 00:00:34 UTC) #3
Tom Sepez
5 years ago (2015-12-05 00:21:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
59d09dfd276aa262d6fb95c4a78784fdc1824a26 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698