Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 1499813003: Reland "Added an extra sync token field for extra command buffer..." (Closed)

Created:
5 years ago by David Yen
Modified:
5 years ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, qsr+mojo_chromium.org, rjkroege, sievers+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Added an extra sync token field for extra command buffer..." This reverts commit 5097a2103f86741a7d0e6567e57759be939182b0. R=dalecurtis@chromium.org, dcheng@chromium.org, piman@chromium.org, sky@chromium.org BUG=514815, 566291 Committed: https://crrev.com/1ed246478fcfa39bcf1f617ae35cfc4fdf5bad8b Cr-Commit-Position: refs/heads/master@{#363922}

Patch Set 1 #

Patch Set 2 : Enforce stream ids must be non-zero, default stream id is 1 #

Total comments: 4

Patch Set 3 : Changed default streamid to -1 and added DCHECKs to ensure valid stream ids #

Patch Set 4 : Fixed sync token fuzzer parameters #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -24 lines) Patch
M components/mus/gles2/command_buffer_local.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/gles2/command_buffer_local.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.cc View 1 4 chunks +20 lines, -3 lines 0 comments Download
M content/common/gpu/client/gpu_channel_host.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M content/common/gpu/client/gpu_channel_host.cc View 1 2 2 chunks +15 lines, -1 line 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/client/client_test_helper.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 4 chunks +8 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gpu_control.h View 1 chunk +5 lines, -1 line 0 comments Download
M gpu/command_buffer/common/constants.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/common/sync_token.h View 6 chunks +15 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 6 chunks +12 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/mailbox_manager_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/gles2_conform_support/egl/display.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/gles2_conform_support/egl/display.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/ipc/gpu_command_buffer_traits.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/video_frame_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M mojo/converters/surfaces/surfaces_type_converters.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ppapi/proxy/ppapi_command_buffer_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/ppapi_command_buffer_proxy.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/ipc_fuzzer/fuzzer/fuzzer.cc View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 23 (7 generated)
David Yen
Attempting to reland this patch. The previous patch failed because currently we do not assign ...
5 years ago (2015-12-04 22:39:57 UTC) #1
piman
https://codereview.chromium.org/1499813003/diff/20001/content/common/gpu/client/gpu_channel_host.cc File content/common/gpu/client/gpu_channel_host.cc (right): https://codereview.chromium.org/1499813003/diff/20001/content/common/gpu/client/gpu_channel_host.cc#newcode76 content/common/gpu/client/gpu_channel_host.cc:76: next_stream_id_.GetNext(); You'll need to bump this too, otherwise the ...
5 years ago (2015-12-04 22:48:46 UTC) #2
David Yen
https://codereview.chromium.org/1499813003/diff/20001/content/common/gpu/client/gpu_channel_host.cc File content/common/gpu/client/gpu_channel_host.cc (right): https://codereview.chromium.org/1499813003/diff/20001/content/common/gpu/client/gpu_channel_host.cc#newcode76 content/common/gpu/client/gpu_channel_host.cc:76: next_stream_id_.GetNext(); On 2015/12/04 22:48:46, piman (slow to review) wrote: ...
5 years ago (2015-12-04 23:30:27 UTC) #3
David Yen
https://codereview.chromium.org/1499813003/diff/20001/content/common/gpu/client/gpu_channel_host.cc File content/common/gpu/client/gpu_channel_host.cc (right): https://codereview.chromium.org/1499813003/diff/20001/content/common/gpu/client/gpu_channel_host.cc#newcode76 content/common/gpu/client/gpu_channel_host.cc:76: next_stream_id_.GetNext(); On 2015/12/04 23:30:27, David Yen wrote: > On ...
5 years ago (2015-12-05 00:01:19 UTC) #4
piman
lgtm https://codereview.chromium.org/1499813003/diff/20001/content/common/gpu/client/gpu_channel_host.cc File content/common/gpu/client/gpu_channel_host.cc (right): https://codereview.chromium.org/1499813003/diff/20001/content/common/gpu/client/gpu_channel_host.cc#newcode76 content/common/gpu/client/gpu_channel_host.cc:76: next_stream_id_.GetNext(); On 2015/12/04 23:30:27, David Yen wrote: > ...
5 years ago (2015-12-05 02:16:25 UTC) #5
dcheng
rs lgtm for ipc
5 years ago (2015-12-05 02:20:56 UTC) #6
sky
LGTM
5 years ago (2015-12-07 16:08:33 UTC) #7
David Yen
+inferno@ for fuzzer review
5 years ago (2015-12-07 18:43:04 UTC) #10
aarya
lgtm for ipc fuzzer change
5 years ago (2015-12-07 18:56:59 UTC) #12
David Yen
On 2015/12/07 18:56:59, aarya wrote: > lgtm for ipc fuzzer change ping DaleCurtis@ for media ...
5 years ago (2015-12-08 18:06:15 UTC) #13
inferno
On 2015/12/08 18:06:15, David Yen wrote: > On 2015/12/07 18:56:59, aarya wrote: > > lgtm ...
5 years ago (2015-12-08 18:08:53 UTC) #14
DaleCurtis
media/ lgtm
5 years ago (2015-12-08 21:42:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499813003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499813003/60001
5 years ago (2015-12-08 22:11:48 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-09 02:23:38 UTC) #20
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/1ed246478fcfa39bcf1f617ae35cfc4fdf5bad8b Cr-Commit-Position: refs/heads/master@{#363922}
5 years ago (2015-12-09 02:25:05 UTC) #22
johnme
5 years ago (2015-12-10 16:48:43 UTC) #23
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1516813003/ by johnme@chromium.org.

The reason for reverting is: Experimental revert - this might be the reason why
all gl_tests are failing on Jelly Bean Tester. See https://crbug.com/568628..

Powered by Google App Engine
This is Rietveld 408576698