Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 14998008: Move llvm.eh.frame.cfa to the blacklist of intrinsics. (Closed)

Created:
7 years, 7 months ago by jvoung (off chromium)
Modified:
7 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/pnacl-llvm.git@master
Visibility:
Public.

Description

Move llvm.eh.frame.cfa to the blacklist of intrinsics. Tests that use them now skip ABI verification. Known tests that use this are the scons tests: - the barebones_stack_alignment16 test and - the EH ones under tests/toolchain/ Also list other eh_* in the blacklist more explicitly (they were already caught by the default case). BUG=https://code.google.com/p/nativeclient/issues/detail?id=3378 TEST= scons, gcc torture, llvm R=dschuff@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=4d0b8cd

Patch Set 1 #

Patch Set 2 : list the others #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M lib/Analysis/NaCl/PNaClABIVerifyModule.cpp View 1 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jvoung (off chromium)
7 years, 7 months ago (2013-05-09 18:20:47 UTC) #1
Derek Schuff
lgtm
7 years, 7 months ago (2013-05-09 19:28:55 UTC) #2
jvoung (off chromium)
7 years, 7 months ago (2013-05-09 20:35:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r4d0b8cd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698