AbstractClassInstantiationError beats NoSuchMethodError

AbstractClassInstantiationError beats NoSuchMethodError

When both errors are determined at compile time,
AbstractClassInstantiationError must win.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/9b75b248ad5678ae24f63bb9563dd3fada0e1722

[sra1, 2015-12-04 00:22:23]

sra@google.com changed reviewers:
+ sigmund@google.com

[sra1, 2015-12-04 00:22:24]

I'm testing it now.

I have to leave now, Siggi - can you finish this?

https://codereview.chromium.org/1499793002/diff/1/pkg/compiler/lib/src/ssa/bu...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://codereview.chromium.org/1499793002/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder.dart:5138: if (checkTypeVariableBounds(node,
type)) return;
TODO (later): in checked mode, does the type variable bounds check win?

[Siggi Cherem (dart-lang), 2015-12-04 00:27:28]

lgtm, thanks Stephen, I'll test it out in checked mode and keep you posted

[Siggi Cherem (dart-lang), 2015-12-04 00:52:45]

everything seems to be working appropriately in checked mode. I'll submit it for
you shortly.

I was not able to understand from the spec whether the type arguments check
should win under check mode, but it appears that is how it is implemented in the
vm today - so the current behavior is at least consistent.

[Siggi Cherem (dart-lang), 2015-12-04 00:56:32]

Description was changed from

==========
AbstractClassInstantiationError beats NoSuchMethodError

When both errors are determined at compile time,
AbstractClassInstantiationError must win.
==========

to

==========
AbstractClassInstantiationError beats NoSuchMethodError

When both errors are determined at compile time,
AbstractClassInstantiationError must win.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9b75b248ad5678ae24f63bb9563dd3fada0e1722
==========

[Siggi Cherem (dart-lang), 2015-12-04 00:56:33]

Committed patchset #1 (id:1) manually as
9b75b248ad5678ae24f63bb9563dd3fada0e1722 (presubmit successful).