Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 14997008: Add a HBreak instruction for debugging (Closed)

Created:
7 years, 7 months ago by oliv
Modified:
7 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Add a HBreak instruction for debugging BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14691

Patch Set 1 : #

Total comments: 1

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -0 lines) Patch
M src/arm/lithium-arm.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 chunks +12 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/mips/lithium-mips.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/x64/lithium-x64.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jakob Kummerow
LGTM if you address my comment below. https://codereview.chromium.org/14997008/diff/7001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/14997008/diff/7001/src/hydrogen-instructions.h#newcode1467 src/hydrogen-instructions.h:1467: class HBreak: ...
7 years, 7 months ago (2013-05-15 11:23:36 UTC) #1
oliv
7 years, 7 months ago (2013-05-15 14:24:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r14691 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698