tests/compiler/dart2js/simple_inferrer_final_field_test.dart - Issue 14997006: Introduce a UnionTypeMask, currently limited to 4 types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/simple_inferrer_final_field_test.dart

Issue 14997006: Introduce a UnionTypeMask, currently limited to 4 types. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tests/compiler/dart2js/simple_inferrer_final_field3_test.dart ('k') | tests/compiler/dart2js/simple_inferrer_no_such_method_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/compiler/dart2js/simple_inferrer_final_field_test.dart

===================================================================

--- tests/compiler/dart2js/simple_inferrer_final_field_test.dart (revision 23010)

+++ tests/compiler/dart2js/simple_inferrer_final_field_test.dart (working copy)

@@ -34,12 +34,14 @@

checkFieldTypeInClass(String className, String fieldName, type) {

var cls = findElement(compiler, className);

var element = cls.lookupLocalMember(buildSourceString(fieldName));

- Expect.equals(type, typesInferrer.internal.typeOf[element]);

+ Expect.equals(type,

+ typesInferrer.internal.typeOf[element].simplify(compiler));

}

checkFieldTypeInClass('A', 'intField', typesInferrer.intType);

checkFieldTypeInClass('A', 'giveUpField1',

findTypeMask(compiler, 'Interceptor', 'nonNullSubclass'));

- checkFieldTypeInClass('A', 'giveUpField2', typesInferrer.dynamicType);

+ checkFieldTypeInClass('A', 'giveUpField2',

+ typesInferrer.dynamicType.nonNullable());

checkFieldTypeInClass('A', 'fieldParameter', typesInferrer.intType);

}