Clip long host names.

Clip long host names.

Prevent long host names with no spaces from overflowing. Without this
change, the edit and delete buttons are partially covered, making them
hard to click.

BUG=553656
Committed: https://crrev.com/b1c0f07eee1372e8ff75668eb7afd1e6bf5d597a
Cr-Commit-Position: refs/heads/master@{#363559}

[Jamie, 2015-12-03 23:55:45]

jamiewalch@chromium.org changed reviewers:
+ kelvinp@chromium.org

[Jamie, 2015-12-03 23:55:45]

ptal

[kelvinp, 2015-12-04 20:12:21]

https://codereview.chromium.org/1499693003/diff/1/remoting/webapp/base/html/m...
File remoting/webapp/base/html/main.css (right):

https://codereview.chromium.org/1499693003/diff/1/remoting/webapp/base/html/m...
remoting/webapp/base/html/main.css:513: overflow-x: hidden;
Do you want 

white-space: nowrap;
text-overflow: ellipsis;

as well to show ... when the host name is too long?

[Jamie, 2015-12-05 21:15:28]

ptal

https://codereview.chromium.org/1499693003/diff/1/remoting/webapp/base/html/m...
File remoting/webapp/base/html/main.css (right):

https://codereview.chromium.org/1499693003/diff/1/remoting/webapp/base/html/m...
remoting/webapp/base/html/main.css:513: overflow-x: hidden;
On 2015/12/04 20:12:20, kelvinp wrote:
> Do you want 
> 
> white-space: nowrap;
> text-overflow: ellipsis;
> 
> as well to show ... when the host name is too long?

I've added an ellipsis, but I want to keep word wrap, otherwise the last-online
text is lost (with word wrap it falls on a separate line). I might be able to
make this work by putting that information in a separate <span> so that only the
name is truncated, which would have the advantage that each host is a consistent
height, even if the name is very long. The downside is that most people who set
a very long hostname will include spaces, so we'd be hiding part of the name
that is currently visible, albeit on a different line. I don't think that's the
right trade-off.

[kelvinp, 2015-12-07 18:46:39]

lgtm

[Jamie, 2015-12-07 18:59:02]

The CQ bit was checked by jamiewalch@chromium.org

[commit-bot: I haz the power, 2015-12-07 19:04:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1499693003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1499693003/20001

[commit-bot: I haz the power, 2015-12-07 20:10:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-07 20:11:08]

Description was changed from

==========
Clip long host names.

Prevent long host names with no spaces from overflowing. Without this
change, the edit and delete buttons are partially covered, making them
hard to click.

BUG=553656
==========

to

==========
Clip long host names.

Prevent long host names with no spaces from overflowing. Without this
change, the edit and delete buttons are partially covered, making them
hard to click.

BUG=553656

Committed: https://crrev.com/b1c0f07eee1372e8ff75668eb7afd1e6bf5d597a
Cr-Commit-Position: refs/heads/master@{#363559}
==========

[commit-bot: I haz the power, 2015-12-07 20:11:09]

Patchset 2 (id:??) landed as
https://crrev.com/b1c0f07eee1372e8ff75668eb7afd1e6bf5d597a
Cr-Commit-Position: refs/heads/master@{#363559}