tracing: Add macros for generating context trace events

tracing: Add macros for generating context trace events

These macros can be used to annotate sections of code that are working
on specific trace contexts. For example, to mark a piece of code as
belonging to a particular HTML frame:

  TRACE_EVENT_ENTER_CONTEXT("blink", "FrameContext", &my_frame);
  // Do something with |my_frame|.
  TRACE_EVENT_LEAVE_CONTEXT("blink", "FrameContext", &my_frame);

The patch also adds a scoped helper:

  TraceScopedContext scoped_context("blink", "FrameContext", &my_frame);

For more details see the design doc:

https://docs.google.com/document/d/15BB-suCb9j-nFt55yCFJBJCGzLg2qUm3WaSOPb8APtI/edit?pli=1#heading=h.4lvgp19u6rwx

BUG=546021
Committed: https://crrev.com/29ffcdce7014502105f8d95a97259c910ba3b8be
Cr-Commit-Position: refs/heads/master@{#370976}

[Sami, 2016-01-19 11:57:18]

Description was changed from

==========
tracing: Add macros for generating context trace events

These macros can be used to annotate sections of code that are working
on specific trace contexts. For more details see the design doc:

https://docs.google.com/document/d/15BB-suCb9j-nFt55yCFJBJCGzLg2qUm3WaSOPb8AP...

BUG=546021
==========

to

==========
tracing: Add macros for generating context trace events

These macros can be used to annotate sections of code that are working
on specific trace contexts. For example, to mark a piece of code as
belonging to a particular HTML frame:

  TRACE_EVENT_ENTER_CONTEXT("blink", "FrameContext", &my_frame);
  // Do something with |my_frame|.
  TRACE_EVENT_LEAVE_CONTEXT("blink", "FrameContext", &my_frame);

The patch also adds a scoped helper:

  TraceScopedContext scoped_context("blink", "FrameContext", &my_frame);

For more details see the design doc:

https://docs.google.com/document/d/15BB-suCb9j-nFt55yCFJBJCGzLg2qUm3WaSOPb8AP...

BUG=546021
==========

[Sami, 2016-01-19 12:07:32]

skyostil@chromium.org changed reviewers:
+ benjhayden@chromium.org, chiniforooshan@chromium.org, nduca@chromium.org

[fmeawad, 2016-01-19 18:38:09]

fmeawad@chromium.org changed reviewers:
+ fmeawad@chromium.org

[fmeawad, 2016-01-19 18:38:10]

non-owner LGTM

https://codereview.chromium.org/1499683002/diff/1/base/trace_event/trace_event.h
File base/trace_event/trace_event.h (right):

https://codereview.chromium.org/1499683002/diff/1/base/trace_event/trace_even...
base/trace_event/trace_event.h:343: scoped_trace)(category_group, name, context)
Can you move this to common as well, I do not see anything platform specific in
the TraceScopedContext and it would make it easier to start using everywhere?

[chiniforooshan, 2016-01-19 19:18:15]

On 2016/01/19 12:08:01, Sami wrote:

lgtm

[benjhayden, 2016-01-19 22:37:08]

lgtm

[Sami, 2016-01-20 10:34:08]

Thanks for taking a look.

https://codereview.chromium.org/1499683002/diff/1/base/trace_event/trace_event.h
File base/trace_event/trace_event.h (right):

https://codereview.chromium.org/1499683002/diff/1/base/trace_event/trace_even...
base/trace_event/trace_event.h:343: scoped_trace)(category_group, name, context)
On 2016/01/19 18:38:10, fmeawad wrote:
> Can you move this to common as well, I do not see anything platform specific
in
> the TraceScopedContext and it would make it easier to start using everywhere?

Yeah, I wasn't sure where we draw the line. I didn't see any classes or
namespace declarations in common -- does it make sense to start declaring these
kind of things there?

TraceScopeContext uses DISALLOW_COPY_AND_ASSIGN which is kinda sorta platform
specific.

[nduca, 2016-01-21 19:03:30]

lgtm

[Sami, 2016-01-22 10:43:40]

skyostil@chromium.org changed reviewers:
+ mkwst@chromium.org

[Sami, 2016-01-22 10:44:59]

Mike, could you check third_party/WebKit/Source/platform/?

[Mike West, 2016-01-22 12:47:17]

LGTM.

[Sami, 2016-01-22 12:49:12]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2016-01-22 12:49:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1499683002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1499683002/1

[commit-bot: I haz the power, 2016-01-22 12:51:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-22 12:51:35]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Sami, 2016-01-22 12:54:04]

The CQ bit was checked by skyostil@chromium.org

[Sami, 2016-01-22 12:54:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
benjhayden@chromium.org, chiniforooshan@chromium.org, mkwst@chromium.org,
fmeawad@chromium.org, nduca@chromium.org
Link to the patchset: https://codereview.chromium.org/1499683002/#ps20001
(title: "Rebased.")

[commit-bot: I haz the power, 2016-01-22 12:54:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1499683002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1499683002/20001

[commit-bot: I haz the power, 2016-01-22 16:04:35]

Description was changed from

==========
tracing: Add macros for generating context trace events

These macros can be used to annotate sections of code that are working
on specific trace contexts. For example, to mark a piece of code as
belonging to a particular HTML frame:

  TRACE_EVENT_ENTER_CONTEXT("blink", "FrameContext", &my_frame);
  // Do something with |my_frame|.
  TRACE_EVENT_LEAVE_CONTEXT("blink", "FrameContext", &my_frame);

The patch also adds a scoped helper:

  TraceScopedContext scoped_context("blink", "FrameContext", &my_frame);

For more details see the design doc:

https://docs.google.com/document/d/15BB-suCb9j-nFt55yCFJBJCGzLg2qUm3WaSOPb8AP...

BUG=546021
==========

to

==========
tracing: Add macros for generating context trace events

These macros can be used to annotate sections of code that are working
on specific trace contexts. For example, to mark a piece of code as
belonging to a particular HTML frame:

  TRACE_EVENT_ENTER_CONTEXT("blink", "FrameContext", &my_frame);
  // Do something with |my_frame|.
  TRACE_EVENT_LEAVE_CONTEXT("blink", "FrameContext", &my_frame);

The patch also adds a scoped helper:

  TraceScopedContext scoped_context("blink", "FrameContext", &my_frame);

For more details see the design doc:

https://docs.google.com/document/d/15BB-suCb9j-nFt55yCFJBJCGzLg2qUm3WaSOPb8AP...

BUG=546021
==========

[commit-bot: I haz the power, 2016-01-22 16:04:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-22 16:06:40]

Description was changed from

==========
tracing: Add macros for generating context trace events

These macros can be used to annotate sections of code that are working
on specific trace contexts. For example, to mark a piece of code as
belonging to a particular HTML frame:

  TRACE_EVENT_ENTER_CONTEXT("blink", "FrameContext", &my_frame);
  // Do something with |my_frame|.
  TRACE_EVENT_LEAVE_CONTEXT("blink", "FrameContext", &my_frame);

The patch also adds a scoped helper:

  TraceScopedContext scoped_context("blink", "FrameContext", &my_frame);

For more details see the design doc:

https://docs.google.com/document/d/15BB-suCb9j-nFt55yCFJBJCGzLg2qUm3WaSOPb8AP...

BUG=546021
==========

to

==========
tracing: Add macros for generating context trace events

These macros can be used to annotate sections of code that are working
on specific trace contexts. For example, to mark a piece of code as
belonging to a particular HTML frame:

  TRACE_EVENT_ENTER_CONTEXT("blink", "FrameContext", &my_frame);
  // Do something with |my_frame|.
  TRACE_EVENT_LEAVE_CONTEXT("blink", "FrameContext", &my_frame);

The patch also adds a scoped helper:

  TraceScopedContext scoped_context("blink", "FrameContext", &my_frame);

For more details see the design doc:

https://docs.google.com/document/d/15BB-suCb9j-nFt55yCFJBJCGzLg2qUm3WaSOPb8AP...

BUG=546021

Committed: https://crrev.com/29ffcdce7014502105f8d95a97259c910ba3b8be
Cr-Commit-Position: refs/heads/master@{#370976}
==========

[commit-bot: I haz the power, 2016-01-22 16:06:41]

Patchset 2 (id:??) landed as
https://crrev.com/29ffcdce7014502105f8d95a97259c910ba3b8be
Cr-Commit-Position: refs/heads/master@{#370976}

[bekkilair77, 2016-04-10 14:08:12]

bekkilair77@gmail.com changed reviewers:
+ bekkilair77@gmail.com

[bekkilair77, 2016-04-10 14:11:50]

lgtm

commit-bot: I haz the power

[bekkilair77, 2016-04-10 14:35:16]

lgtm

commit-bot: I haz the power