Issue 149963004: Add checklicenses exception for new location of clang_format scripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149963004: Add checklicenses exception for new location of clang_format scripts. (Closed)

Created:
6 years, 10 months ago by Nico

Modified:
6 years, 10 months ago

Reviewers:
ncarter (slow)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add checklicenses exception for new location of clang_format scripts. BUG=240309, 333093, 333508 TBR=nick@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248408

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	tools/checklicenses/checklicenses.py	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

Committed patchset #1 manually as r248408 (presubmit successful).

6 years, 10 months ago (2014-02-02 16:04:35 UTC) #1

ncarter (slow)

6 years, 10 months ago (2014-02-02 18:50:13 UTC) #2

Lgtm
On Feb 2, 2014 8:04 AM, <thakis@chromium.org> wrote:

> Reviewers: ncarter,
>
> Message:
> Committed patchset #1 manually as r248408 (presubmit successful).
>
> Description:
> Add checklicenses exception for new location of clang_format scripts.
>
> BUG=240309,333093,333508
> TBR=nick@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248408
>
> Please review this at https://codereview.chromium.org/149963004/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+3, -0 lines):
>   M tools/checklicenses/checklicenses.py
>
>
> Index: tools/checklicenses/checklicenses.py
> diff --git a/tools/checklicenses/checklicenses.py b/tools/checklicenses/
> checklicenses.py
> index 7cd0a4f4a3e747fefe37d9d2ee004d810142b572..
> 6f950b7dea45ab38090f84f8c174bd0dc32964b9 100755
> --- a/tools/checklicenses/checklicenses.py
> +++ b/tools/checklicenses/checklicenses.py
> @@ -163,6 +163,9 @@ PATH_SPECIFIC_WHITELISTED_LICENSES = {
>      ],
>
>      # http://crbug.com/333508
> +    'third_party/clang_format/script': [
> +        'UNKNOWN',
> +    ],
>      'third_party/clang_format/scripts': [
>          'UNKNOWN',
>      ],
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Expand Messages | Collapse Messages