Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 149963002: [android_webview] Set 'fling active' flag only from computeScroll. (Closed)

Created:
6 years, 10 months ago by mkosiba (inactive)
Modified:
6 years, 10 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@deleteme
Visibility:
Public.

Description

[android_webview] Set 'fling active' flag only from computeScroll. This prevents us getting stuck in smoothness mode if the embedding application inhibits the View.computeScroll callback. BUG=339245 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247930

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mkosiba (inactive)
Hey Bo, would you mind checking if this actually works (I'm 99% sure it should, ...
6 years, 10 months ago (2014-01-30 01:49:43 UTC) #1
boliu
On 2014/01/30 01:49:43, mkosiba wrote: > Hey Bo, would you mind checking if this actually ...
6 years, 10 months ago (2014-01-30 02:04:09 UTC) #2
boliu
On 2014/01/30 02:04:09, boliu wrote: > On 2014/01/30 01:49:43, mkosiba wrote: > > Hey Bo, ...
6 years, 10 months ago (2014-01-30 02:05:13 UTC) #3
boliu
This seems to go too far the other way, now we are not in smoothness ...
6 years, 10 months ago (2014-01-30 02:13:30 UTC) #4
boliu
lgtm
6 years, 10 months ago (2014-01-30 02:33:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/149963002/1
6 years, 10 months ago (2014-01-30 06:42:39 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 10:43:59 UTC) #7
Message was sent while issue was closed.
Change committed as 247930

Powered by Google App Engine
This is Rietveld 408576698