src/objects.cc - Issue 1499593003: [runtime] [proxy] Implementing [[Call]]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 1499593003: [runtime] [proxy] Implementing [[Call]] (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: adding dcheck Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index e1cd390d7bc612c9a0cadcc166f79f1cad4a32cd..ddcba5987d18b22d94f216b37e852844caf217c3 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -997,7 +997,7 @@ MaybeHandle<Object> JSProxy::GetPrototype(Handle<JSProxy> proxy) {

if (is_extensible.FromJust()) return handler_proto;

// 11. Let targetProto be ? target.[[GetPrototypeOf]]().

Handle<Object> target_proto;

- ASSIGN_RETURN_ON_EXCEPTION(isolate, handler_proto,

+ ASSIGN_RETURN_ON_EXCEPTION(isolate, target_proto,

Jakob Kummerow 2015/12/07 15:55:07 Why did existing tests not catch this? Maybe add a

Camillo Bruni 2015/12/07 16:54:10 kept a note. will do in a separate cl.

Object::GetPrototype(isolate, target), Object);

// 12. If SameValue(handlerProto, targetProto) is false, throw a TypeError.

if (!handler_proto->SameValue(*target_proto)) {