Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1499593002: [Interpreter] Adds support for Increment and Decrement to BytecodeGraphBuilder. (Closed)

Created:
5 years ago by mythria
Modified:
5 years ago
Reviewers:
Benedikt Meurer, oth
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Adds support for Increment and Decrement to BytecodeGraphBuilder. Adds implementation and tests for Inc and Dec to bytecode graph builder. BUG=v8:4280 LOG=N Committed: https://crrev.com/75f1102129d87884aeed6138c44ca6a3d21f2f34 Cr-Commit-Position: refs/heads/master@{#32562}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -2 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 chunk +14 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mythria
Could you please review my changes Thanks, Mythri
5 years ago (2015-12-03 11:56:32 UTC) #2
Benedikt Meurer
LGTM.
5 years ago (2015-12-03 11:58:57 UTC) #3
oth
lgtm
5 years ago (2015-12-03 13:00:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499593002/1
5 years ago (2015-12-03 13:02:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 13:20:34 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-03 13:21:20 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75f1102129d87884aeed6138c44ca6a3d21f2f34
Cr-Commit-Position: refs/heads/master@{#32562}

Powered by Google App Engine
This is Rietveld 408576698