[Findit] Add a model to provide versioning and also a verioned config model.

[Findit] Add a model to provide versioning and also a verioned config model.

BUG=

Committed: https://chromium.googlesource.com/infra/infra/+/d8fab50cdbb88daaf6b1b149e2ee142d7d05916f

[stgao, 2015-12-03 08:26:55]

stgao@chromium.org changed reviewers:
+ chanli@chromium.org, lijeffrey@chromium.org

[stgao, 2015-12-03 08:26:56]

ptal

[lijeffrey1, 2015-12-03 18:51:37]

lijeffrey@google.com changed reviewers:
+ lijeffrey@google.com

[lijeffrey1, 2015-12-03 18:51:37]

https://codereview.chromium.org/1499583002/diff/1/appengine/findit/model/test...
File appengine/findit/model/test/versioned_model_test.py (right):

https://codereview.chromium.org/1499583002/diff/1/appengine/findit/model/test...
appengine/findit/model/test/versioned_model_test.py:64: def
testLiklyTransactionFailure(self):
nit: likely

https://codereview.chromium.org/1499583002/diff/1/appengine/findit/model/vers...
File appengine/findit/model/versioned_model.py (right):

https://codereview.chromium.org/1499583002/diff/1/appengine/findit/model/vers...
appengine/findit/model/versioned_model.py:65: while True:
so is this while True used to perform a retry if an exception occurs during
ndb.transaction()? Will it keep trying forever if ndb.transaction repeatedly
raises exceptions?

[stgao, 2015-12-03 19:43:48]

Description was changed from

==========
[Findit] Add a model to provide versioning.

BUG=
==========

to

==========
[Findit] Add a model to provide versioning and also a verioned config model.

BUG=
==========

[stgao, 2015-12-03 19:43:56]

https://codereview.chromium.org/1499583002/diff/1/appengine/findit/model/test...
File appengine/findit/model/test/versioned_model_test.py (right):

https://codereview.chromium.org/1499583002/diff/1/appengine/findit/model/test...
appengine/findit/model/test/versioned_model_test.py:64: def
testLiklyTransactionFailure(self):
On 2015/12/03 18:51:37, lijeffrey1 wrote:
> nit: likely

Done.

https://codereview.chromium.org/1499583002/diff/1/appengine/findit/model/vers...
File appengine/findit/model/versioned_model.py (right):

https://codereview.chromium.org/1499583002/diff/1/appengine/findit/model/vers...
appengine/findit/model/versioned_model.py:65: while True:
On 2015/12/03 18:51:37, lijeffrey1 wrote:
> so is this while True used to perform a retry if an exception occurs during
> ndb.transaction()? Will it keep trying forever if ndb.transaction repeatedly
> raises exceptions?

Yes, this is to retry for exception or key already used.

As datastore has high availability, I don't expect this to run forever.

[lijeffrey, 2015-12-03 19:48:28]

lgtm

[stgao, 2015-12-03 19:50:55]

The CQ bit was checked by stgao@chromium.org

[commit-bot: I haz the power, 2015-12-03 19:51:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1499583002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1499583002/20001

[commit-bot: I haz the power, 2015-12-03 20:56:12]

Description was changed from

==========
[Findit] Add a model to provide versioning and also a verioned config model.

BUG=
==========

to

==========
[Findit] Add a model to provide versioning and also a verioned config model.

BUG=

Committed:
https://chromium.googlesource.com/infra/infra/+/d8fab50cdbb88daaf6b1b149e2ee1...
==========

[commit-bot: I haz the power, 2015-12-03 20:56:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/d8fab50cdbb88daaf6b1b149e2ee1...