Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1499573004: Remove (now) unused GetPropertyWithHandler. (Closed)

Created:
5 years ago by neis
Modified:
5 years ago
Reviewers:
Camillo Bruni, rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove (now) unused GetPropertyWithHandler. R=cbruni@chromium.org BUG= Committed: https://crrev.com/8a70e9f9870d68a4160dbb0fa9e2c68b803bbc74 Cr-Commit-Position: refs/heads/master@{#32578}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M src/objects.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
neis
5 years ago (2015-12-03 12:32:07 UTC) #1
Camillo Bruni
lgtm
5 years ago (2015-12-03 14:59:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499573004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499573004/1
5 years ago (2015-12-03 15:01:18 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8490)
5 years ago (2015-12-03 15:07:06 UTC) #6
rossberg
lgtm
5 years ago (2015-12-03 15:21:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499573004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499573004/1
5 years ago (2015-12-03 15:23:26 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 16:50:30 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-03 16:51:06 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a70e9f9870d68a4160dbb0fa9e2c68b803bbc74
Cr-Commit-Position: refs/heads/master@{#32578}

Powered by Google App Engine
This is Rietveld 408576698