Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1385)

Issue 1499533002: Fix some inference corner case crashes (Closed)

Created:
5 years ago by Leaf
Modified:
5 years ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix some inference corner case crashes. Running the DDC language tests against the bleeding edge analyzer exposed a few small issues, this fixes the crashers. BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/500efa1e7def4f0fde13867ae02e498b256d3109

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/type_system.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Leaf
5 years ago (2015-12-03 01:20:40 UTC) #3
Jennifer Messerly
LGTM! Thank you!
5 years ago (2015-12-03 01:32:08 UTC) #4
Leaf
5 years ago (2015-12-03 05:43:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
500efa1e7def4f0fde13867ae02e498b256d3109 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698