Issue 149953006: Use Android-specific icudata file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149953006: Use Android-specific icudata file (Closed)

Created:
6 years, 10 months ago by jungshik at Google

Modified:
6 years, 10 months ago

Reviewers:
Mark Mentovai, Andrew Hayden (chromium.org)

CC:
chromium-reviews, Xianzhu, andrewhayden, Torne, Miguel Garcia

Base URL:
svn://chrome-svn/chrome/trunk/deps/third_party/icu46/

Visibility:
Public.

Use Android-specific icudata file Android build needs to use a separate icu data file. When icu_use_data_file_flag is on, it has to copy android/icudtl.dat. The Chrome-side of change is https://codereview.chromium.org/156333002/ BUG=72633 TEST=When rolled in in DEPS, Linux/Mac/Windows builds go as before (i.e. have third_party/icu/source/data/in/icudtl.dat copied to the top build directory). R=andrewhayden@chromium.org, mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249466

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -3 lines)			Patch
	M	icu.gyp	View	1	2 chunks	+11 lines, -3 lines	0 comments	Download

Total messages: 5 (0 generated)

jungshik at Google

6 years, 10 months ago (2014-02-06 18:57:05 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r249466 (presubmit successful).