LayoutTests/editing/deleting/delete-uneditable-style.html - Issue 14995014: Don't move uneditable style and link elements during deletion

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/deleting/delete-uneditable-style.html

Issue 14995014: Don't move uneditable style and link elements during deletion (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: 2013-05-14T12:59 Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <script src="../../resources/dump-as-markup.js"></script>

	2 <script>

	3 Markup.description('Test case for crash bug http://crbug.com/177470');

	4 Markup.noAutoDump();

	5 function $(id) { return document.getElementById(id); }

	6 window.addEventListener('load', function() {
	ojan 2013/05/14 05:27:22 This is fine. Another way you could do this would This is fine. Another way you could do this would be to run the script in a script tag right after the contentEditable element. Then you wouldn't need to do it on the load event, which means you could use the dump-as-markup auto dumping and wouldn't need any of the Markup calls. Just including the dump-as-markup script would be enough. yosin_UTC9 2013/05/14 06:17:08 Done. Show quoted text On 2013/05/14 05:27:22, ojan wrote: > This is fine. Another way you could do this would be to run the script in a > script tag right after the contentEditable element. Then you wouldn't need to do > it on the load event, which means you could use the dump-as-markup auto dumping > and wouldn't need any of the Markup calls. Just including the dump-as-markup > script would be enough. Done.
	7 var range = document.createRange();

	8 range.setStart($('start'));

	9 range.setEnd($('end'), NaN);

	10 getSelection().addRange(range);

	11 document.execCommand('delete', null, '');

	12 Markup.dump($('test'));

	13 Markup.notifyDone();

	14 });

	15 </script>

	16 <div contentEditable id="test">

	17 <span id="start">start</span>

	18 editable-1

	19 <div contentEditable="false">

	20 <style>#end { color: red; }</style>

	21 <link type="foo" href="bar">

	22 uneditable

	23 </div>

	24 editable-2

	25 <span id="end">end</span>

	26 </div>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/editing/deleting/delete-uneditable-style-expected.txt » ('j') | no next file with comments »