Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 1499463002: mojo-apptests: Fix detecting failure when no test ran. (Closed)

Created:
5 years ago by sadrul
Modified:
5 years ago
Reviewers:
msw, sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mojo-apptests: Fix detecting failure when no test ran. BUG=none R=msw@chromium.org Committed: https://crrev.com/c36c6282445549860ff359b3a9bc1515a8566e1f Cr-Commit-Position: refs/heads/master@{#362825}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M mojo/tools/apptest_runner.py View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
sadrul
5 years ago (2015-12-02 20:38:25 UTC) #1
sadrul
+sky for owner
5 years ago (2015-12-02 20:38:45 UTC) #3
sky
LGTM
5 years ago (2015-12-02 20:42:29 UTC) #4
sadrul
Hrm, this script is hella confusing. With the first patchset, the mus_wm_apptests passes, but it ...
5 years ago (2015-12-02 20:49:13 UTC) #5
sky
LGTM - I reverted my patch to disable, so it isn't critical to land this ...
5 years ago (2015-12-02 21:10:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499463002/20001
5 years ago (2015-12-02 22:40:38 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-03 00:09:04 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c36c6282445549860ff359b3a9bc1515a8566e1f Cr-Commit-Position: refs/heads/master@{#362825}
5 years ago (2015-12-03 00:09:49 UTC) #11
sky
5 years ago (2015-12-03 04:36:52 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1495783002/ by sky@chromium.org.

The reason for reverting is: Speculative revert as cq is failing in an unusual
way when running mojo_apptests:
'module' object has no attribute 'should_start_xvfb'

from
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium....

Powered by Google App Engine
This is Rietveld 408576698