Remove round trip from data reduction proxy authentication

chrome/browser/profiles/profile_impl_io_data.cc

Index: chrome/browser/profiles/profile_impl_io_data.cc
diff --git a/chrome/browser/profiles/profile_impl_io_data.cc b/chrome/browser/profiles/profile_impl_io_data.cc
index 00e3b6e0406f8278be03d5a4ffaef1c68f4950a0..0bd3c483ad7bcb5363afbbd77ec95ecaf049658e 100644
--- a/chrome/browser/profiles/profile_impl_io_data.cc
+++ b/chrome/browser/profiles/profile_impl_io_data.cc
@@ -15,6 +15,9 @@
 #include "base/string_util.h"
 #include "base/threading/sequenced_worker_pool.h"
 #include "base/threading/worker_pool.h"
+#if defined(OS_ANDROID)

[Yaron, 2013/05/21 18:04:30]

Conditional if-defs go at the bottom

[bengr, 2013/05/22 19:03:15]

Done.

+#include "chrome/app/android/chrome_data_reduction_proxy_android.h"
+#endif
 #include "chrome/browser/custom_handlers/protocol_handler_registry.h"
 #include "chrome/browser/custom_handlers/protocol_handler_registry_factory.h"
 #include "chrome/browser/io_thread.h"
@@ -417,6 +420,12 @@ void ProfileImplIOData::InitializeInternal(
       network_session_params, main_backend);
   main_cache->InitializeInfiniteCache(lazy_params_->infinite_cache_path);
 
+#if defined(OS_ANDROID)
+  scoped_ptr<ChromeDataReductionProxyAndroid> chrome_data_reduction_proxy(
+      ChromeDataReductionProxyAndroid::Create());
+  chrome_data_reduction_proxy->Init(main_cache->GetSession());
+#endif

[mmenke, 2013/05/22 15:55:50]

Is there a reason not to just do this all in a static function?

[bengr, 2013/05/22 19:03:15]

I was imagining that ChromeDataReductionProxy would eventually construct
credentials for challenges as well, and would cache the results. This CL doesn't
require the objects, so I'm happy to modify the code if you think that's best.
Let me know.

[mmenke, 2013/05/22 19:20:12]

Since this is an "eventually", and it currently seems a little weird as-is,
let's just switch to a static function for now.

+
   if (record_mode || playback_mode) {
     main_cache->set_mode(
         record_mode ? net::HttpCache::RECORD : net::HttpCache::PLAYBACK);