chrome/browser/extensions/extension_service.cc - Issue 14993013: Windows: When an app is updated and its name changes, recreate shortcuts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 14993013: Windows: When an app is updated and its name changes, recreate shortcuts. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Rebase to HEAD. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_service.cc

diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc

index 2cfc14495d5feff32ae24d9208049e49ab16d2bc..15e661e43cfd0df2bda805aeae7d041d97067e98 100644

--- a/chrome/browser/extensions/extension_service.cc

+++ b/chrome/browser/extensions/extension_service.cc

@@ -2427,8 +2427,15 @@ void ExtensionService::FinishDelayedInstallation(

}

void ExtensionService::FinishInstallation(const Extension* extension) {

- bool is_update = GetInstalledExtension(extension->id()) != NULL;

- extensions::InstalledExtensionInfo details(extension, is_update);

+ const extensions::Extension* existing_extension =

+ GetInstalledExtension(extension->id());

+ bool is_update = false;

+ std::string old_name;

+ if (existing_extension != NULL) {

koz (OOO until 15th September) 2013/05/17 01:36:19 nit: Just "if (existing_extension) {". It's cleane

Matt Giuca 2013/05/20 01:02:46 Done.

+ is_update = true;

+ old_name = existing_extension->name();

+ }

+ extensions::InstalledExtensionInfo details(extension, is_update, old_name);

content::NotificationService::current()->Notify(

chrome::NOTIFICATION_EXTENSION_INSTALLED,

content::Source<Profile>(profile_),

« no previous file with comments | « apps/shortcut_manager.cc ('k') | chrome/browser/extensions/extension_service_unittest.cc » ('j') | chrome/browser/web_applications/web_app_win.cc » ('J')