Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 1499253002: Revert of chrome: Add support for use_glib=true to wayland server. (Closed)

Created:
5 years ago by stevenjb
Modified:
5 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of chrome: Add support for use_glib=true to wayland server. (patchset #2 id:20001 of https://codereview.chromium.org/1486623003/ ) Reason for revert: crbug.com/566152 Original issue's description: > chrome: Add support for use_glib=true to wayland server. > > This adds a GLib WaylandWatcher implemenatation that allows the > Wayland server to listen for and dispatch messages when using a > GLib message loop. > > BUG=549781 > TEST=build chrome without use_glib=false and run with --enable-wayland-server > > Committed: https://crrev.com/75cd05b4694653d9af4fcc8c5c05f7dae433137d > Cr-Commit-Position: refs/heads/master@{#362719} TBR=jochen@chromium.org,reveman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=549781 Committed: https://crrev.com/cfeeea2c8e840dd67af7463088bf02bf200097d0 Cr-Commit-Position: refs/heads/master@{#363312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -61 lines) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/config/ui.gni View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main_extra_parts_exo.cc View 3 chunks +0 lines, -60 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
stevenjb
Created Revert of chrome: Add support for use_glib=true to wayland server.
5 years ago (2015-12-04 22:40:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499253002/1
5 years ago (2015-12-04 23:02:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-04 23:09:39 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-04 23:14:24 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cfeeea2c8e840dd67af7463088bf02bf200097d0
Cr-Commit-Position: refs/heads/master@{#363312}

Powered by Google App Engine
This is Rietveld 408576698