Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
14992005:
clang: Turn on C++11 on CrOs too. (Closed)
|
Created:
7 years, 7 months ago by Nico Modified:
7 years, 6 months ago Reviewers:
phajdan, Paweł, awong CC:
chromium-reviews Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
Descriptionclang: Turn on C++11 on CrOs too.
This was blocked on the main waterfall linux_chromeos_clang bot migrating
to precise, which has happened now.
I believe all bots that build chromeos with clang are on precise now. If any
turns red, this CL should be reverted.
BUG=none
R=ajwong@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198920
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203221
Patch Set 1 #
Messages
Total messages: 39 (0 generated)
First to stamp wins.
LGTM! On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: > First to stamp wins. > > https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >
Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( -Albert On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > LGTM! > > > On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: > >> First to stamp wins. >> >> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >> > >
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/14992005/1
Message was sent while issue was closed.
Committed patchset #1 manually as r198920 (presubmit successful).
Not sure which e-mail was that... Please let me know if there is something more to do here. Looks like the patch has landed successfully. Paweł On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( > > -Albert > > > On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> LGTM! >> >> >> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >> >>> First to stamp wins. >>> >>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>> >> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
On Wed, May 8, 2013 at 10:32 AM, Paweł Hajdan, Jr. <phajdan.jr@chromium.org>wrote: > Not sure which e-mail was that... > > Please let me know if there is something more to do here. > > Looks like the patch has landed successfully. > It had to be reverted because Linux Chromium OS ASAN Builder is apparently still on Lucid. > > Paweł > > > On Tue, May 7, 2013 at 6:37 PM, Albert J. Wong (王重傑) <ajwong@chromium.org>wrote: > >> Awww...looks like Pawel's e-mail was wrong. Victory...tainted. :( >> >> -Albert >> >> >> On Tue, May 7, 2013 at 6:35 PM, Albert J. Wong (王重傑) <ajwong@chromium.org >> > wrote: >> >>> LGTM! >>> >>> >>> On Tue, May 7, 2013 at 6:34 PM, <thakis@chromium.org> wrote: >>> >>>> First to stamp wins. >>>> >>>> https://codereview.chromium.**org/14992005/<https://codereview.chromium.org/1... >>>> >>> >>> >> >
Message was sent while issue was closed.
Committed patchset #1 manually as r203221 (presubmit successful). |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
