Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: samples/swarm/swarm_ui_lib/view/view.dart

Issue 14992002: More fixes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: samples/swarm/swarm_ui_lib/view/view.dart
diff --git a/samples/swarm/swarm_ui_lib/view/view.dart b/samples/swarm/swarm_ui_lib/view/view.dart
index ac2f1c1f1eacf7111c7cf128952344398d5c8309..efa9501168ee820a164fde582c06012289a6c779 100644
--- a/samples/swarm/swarm_ui_lib/view/view.dart
+++ b/samples/swarm/swarm_ui_lib/view/view.dart
@@ -329,7 +329,8 @@ class View implements Positionable {
}
Future<bool> _measureLayout() {
- final changed = new Completer<bool>();
+ // TODO(10459): code should not use Completer.sync.
+ final changed = new Completer<bool>.sync();
_measureLayoutHelper(changed);
var changedComplete = false;
@@ -352,7 +353,8 @@ class View implements Positionable {
// we're taking pains to not initialize _layout if it's not needed. Is that
// a good tradeoff?
if (ViewLayout.hasCustomLayout(this)) {
- Completer sizeCompleter = new Completer<Size>();
+ // TODO(10459): code should not use Completer.sync.
+ Completer sizeCompleter = new Completer<Size>.sync();
window.setImmediate(() {
sizeCompleter.complete(
new Size(_node.client.width, _node.client.height));
« no previous file with comments | « no previous file | sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698