Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1863)

Unified Diff: net/quic/reliable_quic_stream_test.cc

Issue 1499163002: Fix ASAN test failure in QUIC's CryptoHandshakeMessageTest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@108754896
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/test_tools/quic_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/reliable_quic_stream_test.cc
diff --git a/net/quic/reliable_quic_stream_test.cc b/net/quic/reliable_quic_stream_test.cc
index 6d59478ee54acbd2d94fa485e2f9a96572bbf96c..7ef0defd097bb9c490fd73646d2b0d4cf9dba0ad 100644
--- a/net/quic/reliable_quic_stream_test.cc
+++ b/net/quic/reliable_quic_stream_test.cc
@@ -725,16 +725,6 @@ TEST_F(ReliableQuicStreamTest, FecSendPolicyReceivedConnectionOption) {
EXPECT_EQ(FEC_PROTECT_ALWAYS, stream_->fec_policy());
}
-static QuicConsumedData ConsumeAllData(
- QuicStreamId id,
- const QuicIOVector& data,
- QuicStreamOffset offset,
- bool fin,
- FecProtection fec_protection,
- QuicAckListenerInterface* ack_notifier_delegate) {
- return QuicConsumedData(data.total_length, fin);
-}
-
TEST_F(ReliableQuicStreamTest, EarlyResponseFinHandling) {
// Verify that if the server completes the response before reading the end of
// the request, the received FIN is recorded.
@@ -742,7 +732,7 @@ TEST_F(ReliableQuicStreamTest, EarlyResponseFinHandling) {
Initialize(kShouldProcessData);
EXPECT_CALL(*connection_, SendConnectionClose(_)).Times(0);
EXPECT_CALL(*session_, WritevData(_, _, _, _, _, _))
- .WillRepeatedly(Invoke(ConsumeAllData));
+ .WillRepeatedly(Invoke(MockQuicSpdySession::ConsumeAllData));
// Receive data for the request.
QuicStreamFrame frame1(stream_->id(), false, 0, StringPiece("Start"));
« no previous file with comments | « no previous file | net/quic/test_tools/quic_test_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698