Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1499103002: [crankshaft] Move deopt data population to LCodeGenBase. (Closed)

Created:
5 years ago by Michael Starzinger
Modified:
5 years ago
Reviewers:
Jarin, Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Move deopt data population to LCodeGenBase. R=jkummerow@chromium.org Committed: https://crrev.com/254f9178d1d35988bc1dc9324d75b416f23acf60 Cr-Commit-Position: refs/heads/master@{#32613}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -524 lines) Patch
M src/crankshaft/arm/lithium-codegen-arm.h View 3 chunks +0 lines, -11 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.h View 3 chunks +0 lines, -11 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.h View 3 chunks +0 lines, -11 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M src/crankshaft/lithium-codegen.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/crankshaft/lithium-codegen.cc View 2 chunks +60 lines, -1 line 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.h View 3 chunks +0 lines, -11 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.h View 3 chunks +0 lines, -11 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.h View 3 chunks +0 lines, -11 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.h View 3 chunks +0 lines, -11 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.h View 3 chunks +0 lines, -11 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +0 lines, -54 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Michael Starzinger
5 years ago (2015-12-04 10:31:05 UTC) #1
Jakob Kummerow
I'm strongly opposed to reducing the number of backups like this. Now if just one ...
5 years ago (2015-12-04 13:10:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499103002/1
5 years ago (2015-12-04 13:13:31 UTC) #6
Jarin
lgtm, nice!
5 years ago (2015-12-04 13:14:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-04 13:14:57 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-04 13:15:36 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/254f9178d1d35988bc1dc9324d75b416f23acf60
Cr-Commit-Position: refs/heads/master@{#32613}

Powered by Google App Engine
This is Rietveld 408576698