Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: runtime/vm/intermediate_language_x64.cc

Issue 14991010: Make breakpoints on == fire reliably (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language_mips.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64.
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 541 matching lines...) Expand 10 before | Expand all | Expand 10 after
552 __ jmp(&equality_done); 552 __ jmp(&equality_done);
553 } 553 }
554 } else { 554 } else {
555 // Call stub, load IC data in register. The stub will update ICData if 555 // Call stub, load IC data in register. The stub will update ICData if
556 // necessary. 556 // necessary.
557 Register ic_data_reg = locs->temp(0).reg(); 557 Register ic_data_reg = locs->temp(0).reg();
558 ASSERT(ic_data_reg == RBX); // Stub depends on it. 558 ASSERT(ic_data_reg == RBX); // Stub depends on it.
559 __ LoadObject(ic_data_reg, equality_ic_data); 559 __ LoadObject(ic_data_reg, equality_ic_data);
560 compiler->GenerateCall(token_pos, 560 compiler->GenerateCall(token_pos,
561 &StubCode::EqualityWithNullArgLabel(), 561 &StubCode::EqualityWithNullArgLabel(),
562 PcDescriptors::kOther, 562 PcDescriptors::kEqualNull,
563 locs); 563 locs);
564 __ Drop(2); 564 __ Drop(2);
565 } 565 }
566 __ Bind(&check_ne); 566 __ Bind(&check_ne);
567 if (kind == Token::kNE) { 567 if (kind == Token::kNE) {
568 Label true_label, done; 568 Label true_label, done;
569 // Negate the condition: true label returns false and vice versa. 569 // Negate the condition: true label returns false and vice versa.
570 __ CompareObject(RAX, Bool::True()); 570 __ CompareObject(RAX, Bool::True());
571 __ j(EQUAL, &true_label, Assembler::kNearJump); 571 __ j(EQUAL, &true_label, Assembler::kNearJump);
572 __ LoadObject(RAX, Bool::True()); 572 __ LoadObject(RAX, Bool::True());
(...skipping 3777 matching lines...) Expand 10 before | Expand all | Expand 10 after
4350 PcDescriptors::kOther, 4350 PcDescriptors::kOther,
4351 locs()); 4351 locs());
4352 __ Drop(2); // Discard type arguments and receiver. 4352 __ Drop(2); // Discard type arguments and receiver.
4353 } 4353 }
4354 4354
4355 } // namespace dart 4355 } // namespace dart
4356 4356
4357 #undef __ 4357 #undef __
4358 4358
4359 #endif // defined TARGET_ARCH_X64 4359 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_mips.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698