Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Side by Side Diff: runtime/vm/intermediate_language_ia32.cc

Issue 14991010: Make breakpoints on == fire reliably (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 386 matching lines...) Expand 10 before | Expand all | Expand 10 after
397 __ jmp(&equality_done); 397 __ jmp(&equality_done);
398 } 398 }
399 } else { 399 } else {
400 // Call stub, load IC data in register. The stub will update ICData if 400 // Call stub, load IC data in register. The stub will update ICData if
401 // necessary. 401 // necessary.
402 Register ic_data_reg = locs->temp(0).reg(); 402 Register ic_data_reg = locs->temp(0).reg();
403 ASSERT(ic_data_reg == ECX); // Stub depends on it. 403 ASSERT(ic_data_reg == ECX); // Stub depends on it.
404 __ LoadObject(ic_data_reg, equality_ic_data); 404 __ LoadObject(ic_data_reg, equality_ic_data);
405 compiler->GenerateCall(token_pos, 405 compiler->GenerateCall(token_pos,
406 &StubCode::EqualityWithNullArgLabel(), 406 &StubCode::EqualityWithNullArgLabel(),
407 PcDescriptors::kOther, 407 PcDescriptors::kEqualNull,
408 locs); 408 locs);
409 __ Drop(2); 409 __ Drop(2);
410 } 410 }
411 __ Bind(&check_ne); 411 __ Bind(&check_ne);
412 if (kind == Token::kNE) { 412 if (kind == Token::kNE) {
413 Label true_label, done; 413 Label true_label, done;
414 // Negate the condition: true label returns false and vice versa. 414 // Negate the condition: true label returns false and vice versa.
415 __ CompareObject(EAX, Bool::True()); 415 __ CompareObject(EAX, Bool::True());
416 __ j(EQUAL, &true_label, Assembler::kNearJump); 416 __ j(EQUAL, &true_label, Assembler::kNearJump);
417 __ LoadObject(EAX, Bool::True()); 417 __ LoadObject(EAX, Bool::True());
(...skipping 4289 matching lines...) Expand 10 before | Expand all | Expand 10 after
4707 PcDescriptors::kOther, 4707 PcDescriptors::kOther,
4708 locs()); 4708 locs());
4709 __ Drop(2); // Discard type arguments and receiver. 4709 __ Drop(2); // Discard type arguments and receiver.
4710 } 4710 }
4711 4711
4712 } // namespace dart 4712 } // namespace dart
4713 4713
4714 #undef __ 4714 #undef __
4715 4715
4716 #endif // defined TARGET_ARCH_IA32 4716 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698