third_party/WebKit/LayoutTests/fast/input/placeholder-wrongly-placed-if-too-tall.html - Issue 1499063002: input's placeholder is inconsistently laid out

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/input/placeholder-wrongly-placed-if-too-tall.html

Issue 1499063002: input's placeholder is inconsistently laid out (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added some extra NeedsRebaseline test expectations. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/fast/input/placeholder-wrongly-placed-if-too-tall-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 input {

	4 height: 26px;

	5 line-height: 29px;

	6 padding: 0 5px;

	7 border: none;

	8 border-bottom: 1px solid #888;

	9 outline: none;

	10 }

	11 </style>

	12 <div>Both inputs should be of the same size and the placeholder should be at the same place.</div>

	13 <div id="console"></div>

	14 <input type="text" placeholder="placeholder">

	15 <input type="text" placeholder="placeholder">

	16 <script src="../../resources/js-test.js"></script>

	17 <script>

	18 window.jsTestIsAsync = true;
	mstensho (USE GERRIT) 2015/12/04 14:57:36 What's jsTestIsAsync, Gramps? What's jsTestIsAsync, Gramps? Julien - ping for review 2015/12/04 15:16:33 It's the new hotness in js-test land!!! It is int Show quoted text On 2015/12/04 at 14:57:36, mstensho wrote: > What's jsTestIsAsync, Gramps? It's the new hotness in js-test land!!! It is intended for tests like this one that are asynchronous (ie driven off rAF or setTimeout). By default, js test registers an event listener for DOMContentLoaded to output: "PASS successfullyParsed is true TEST COMPLETE" which doesn't work with our test. That's why you have to set jsTestIsAsync so that we have to explicitly call finishJSTest() when we're done.
	19

	20 if (window.testRunner) {

	21 testRunner.dumpAsText();

	22 testRunner.waitUntilDone();

	23 }

	24

	25 var inputs = document.getElementsByTagName("input");

	26

	27 function checkInputs()

	28 {

	29 rect0 = inputs[0].getBoundingClientRect();

	30 rect1 = inputs[1].getBoundingClientRect();

	31 shouldBe("rect0.top", "rect1.top");

	32 shouldBe("rect0.height", "rect1.height");

	33

	34 if (window.testRunner)

	35 testRunner.notifyDone();

	36

	37 finishJSTest();

	38 }

	39

	40 inputs[1].focus();

	41 // Forcing a layout in this frame makes the issue disappear.

	42 window.requestAnimationFrame(checkInputs);

	43 </script>

OLD	NEW