Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: build/common.gypi

Issue 1499003003: Enable the clang-plugin treat-virtuals-as-complexity flag. Base URL: https://chromium.googlesource.com/chromium/src.git@allow-inline-virtuals
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/clang/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 2206 matching lines...) Expand 10 before | Expand all | Expand 10 after
2217 }], 2217 }],
2218 ], 2218 ],
2219 }, 2219 },
2220 'clang_dynlib_flags%': '-Xclang -load -Xclang <(clang_lib_path) ', 2220 'clang_dynlib_flags%': '-Xclang -load -Xclang <(clang_lib_path) ',
2221 }, { # OS == "win" 2221 }, { # OS == "win"
2222 # On Windows, the plugin is built directly into clang, so there's 2222 # On Windows, the plugin is built directly into clang, so there's
2223 # no need to load it dynamically. 2223 # no need to load it dynamically.
2224 'clang_dynlib_flags%': '', 2224 'clang_dynlib_flags%': '',
2225 }], 2225 }],
2226 ], 2226 ],
2227 'clang_plugin_args%': '-Xclang -plugin-arg-find-bad-constructs -Xclang check-templates ', 2227 'clang_plugin_args%': '-Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang treat-virtuals- as-complexity ',
2228 }, 2228 },
2229 # If you change these, also change build/config/clang/BUILD.gn. 2229 # If you change these, also change build/config/clang/BUILD.gn.
2230 'clang_chrome_plugins_flags%': 2230 'clang_chrome_plugins_flags%':
2231 '<(clang_dynlib_flags)' 2231 '<(clang_dynlib_flags)'
2232 '-Xclang -add-plugin -Xclang find-bad-constructs <(clang_plugin_args)' , 2232 '-Xclang -add-plugin -Xclang find-bad-constructs <(clang_plugin_args)' ,
2233 }], 2233 }],
2234 ['asan==1 or msan==1 or lsan==1 or tsan==1', { 2234 ['asan==1 or msan==1 or lsan==1 or tsan==1', {
2235 'clang%': 1, 2235 'clang%': 1,
2236 'use_allocator%': 'none', 2236 'use_allocator%': 'none',
2237 'use_sanitizer_options%': 1, 2237 'use_sanitizer_options%': 1,
(...skipping 4132 matching lines...) Expand 10 before | Expand all | Expand 10 after
6370 # settings in target dicts. SYMROOT is a special case, because many other 6370 # settings in target dicts. SYMROOT is a special case, because many other
6371 # Xcode variables depend on it, including variables such as 6371 # Xcode variables depend on it, including variables such as
6372 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6372 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6373 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6373 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6374 # files to appear (when present) in the UI as actual files and not red 6374 # files to appear (when present) in the UI as actual files and not red
6375 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6375 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6376 # and therefore SYMROOT, needs to be set at the project level. 6376 # and therefore SYMROOT, needs to be set at the project level.
6377 'SYMROOT': '<(DEPTH)/xcodebuild', 6377 'SYMROOT': '<(DEPTH)/xcodebuild',
6378 }, 6378 },
6379 } 6379 }
OLDNEW
« no previous file with comments | « no previous file | build/config/clang/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698