Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 14990009: Remove core/platform/text/chromium/ and move the files in the directory one level higher. (Closed)

Created:
7 years, 7 months ago by lgombos
Modified:
7 years, 7 months ago
CC:
blink-reviews, jeez, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

WebKit maintained several port specific directories, such as gtk, qt, chromium. In blink a similar separation of port specific directories is not only not necessary but it is going to be challenging to enforce. Remove core/platform/text/chromium/ and move the files in the directory one level higher. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150173

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -98 lines) Patch
M Source/core/core.gypi View 3 chunks +2 lines, -2 lines 0 comments Download
A + Source/core/platform/text/Hyphenation.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/platform/text/TextBreakIteratorInternalICU.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
D Source/core/platform/text/chromium/Hyphenation.cpp View 1 chunk +0 lines, -44 lines 0 comments Download
D Source/core/platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp View 1 chunk +0 lines, -50 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
lgombos
There are many chromium directories in the tree. I just picked one to discuss if ...
7 years, 7 months ago (2013-05-11 16:37:20 UTC) #1
abarth-chromium
lgtm Yeah, I think we should do this throughout the codebase.
7 years, 7 months ago (2013-05-11 18:48:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14990009/1
7 years, 7 months ago (2013-05-11 18:49:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14990009/1
7 years, 7 months ago (2013-05-11 19:02:31 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=4757
7 years, 7 months ago (2013-05-11 21:23:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14990009/1
7 years, 7 months ago (2013-05-11 21:40:24 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-05-11 22:01:03 UTC) #7
Message was sent while issue was closed.
Change committed as 150173

Powered by Google App Engine
This is Rietveld 408576698