chrome/browser/ui/views/browser_action_view.cc - Issue 14990002: Make sure keybindings removed don't come back during extension update.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/browser_action_view.cc

Issue 14990002: Make sure keybindings removed don't come back during extension update. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Moving API calls out of ExtensionPrefs class Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/browser_action_view.cc

diff --git a/chrome/browser/ui/views/browser_action_view.cc b/chrome/browser/ui/views/browser_action_view.cc

index efe8e713229580363cf15becdba07a25f1f2b2b9..68dd81ba079d26b348787d7232e726d8f0686bfa 100644

--- a/chrome/browser/ui/views/browser_action_view.cc

+++ b/chrome/browser/ui/views/browser_action_view.cc

@@ -407,5 +407,6 @@ void BrowserActionButton::MaybeUnregisterExtensionCommand(bool only_if_active) {

&browser_action_command,

NULL)) {

GetFocusManager()->UnregisterAccelerator(*keybinding_.get(), this);

+ keybinding_.reset(NULL);

}

« no previous file with comments | « chrome/browser/extensions/extension_prefs.cc ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »