Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1250)

Unified Diff: chrome/browser/extensions/api/commands/command_service.h

Issue 14990002: Make sure keybindings removed don't come back during extension update. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Moving API calls out of ExtensionPrefs class Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/commands/command_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/commands/command_service.h
diff --git a/chrome/browser/extensions/api/commands/command_service.h b/chrome/browser/extensions/api/commands/command_service.h
index 50c0af7d8eba5d276904ae2c31593c176b9e0728..8270e01e08a3613e9b081765495d892fb17b888d 100644
--- a/chrome/browser/extensions/api/commands/command_service.h
+++ b/chrome/browser/extensions/api/commands/command_service.h
@@ -109,6 +109,12 @@ class CommandService : public ProfileKeyedAPI,
std::string command_name,
bool allow_overrides);
+ // Removes all keybindings for a given extension by its |extension_id|.
+ // |command_name| is optional and if specified, causes only the command with
+ // the name |command_name| to be removed.
+ void RemoveKeybindingPrefs(const std::string& extension_id,
+ const std::string& command_name);
+
// Update the keybinding prefs (for a command with a matching |extension_id|
// and |command_name|) to |keystroke|. If the command had another key assigned
// that key assignment will be removed.
@@ -151,12 +157,6 @@ class CommandService : public ProfileKeyedAPI,
// keybinding assignment.
void AssignInitialKeybindings(const extensions::Extension* extension);
- // Removes all keybindings for a given extension by its |extension_id|.
- // |command_name| is optional and if specified, causes only the command with
- // the name |command_name| to be removed.
- void RemoveKeybindingPrefs(const std::string& extension_id,
- const std::string& command_name);
-
bool GetExtensionActionCommand(const std::string& extension_id,
QueryType query_type,
extensions::Command* command,
« no previous file with comments | « no previous file | chrome/browser/extensions/api/commands/command_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698