Make sure keybindings removed don't come back during extension update.

chrome/browser/ui/views/browser_action_view.cc

Index: chrome/browser/ui/views/browser_action_view.cc
diff --git a/chrome/browser/ui/views/browser_action_view.cc b/chrome/browser/ui/views/browser_action_view.cc
index efe8e713229580363cf15becdba07a25f1f2b2b9..68dd81ba079d26b348787d7232e726d8f0686bfa 100644
--- a/chrome/browser/ui/views/browser_action_view.cc
+++ b/chrome/browser/ui/views/browser_action_view.cc
@@ -407,5 +407,6 @@ void BrowserActionButton::MaybeUnregisterExtensionCommand(bool only_if_active) {
           &browser_action_command,
           NULL)) {
     GetFocusManager()->UnregisterAccelerator(*keybinding_.get(), this);
+    keybinding_.reset(NULL);

[Yoyo Zhou, 2013/05/06 18:47:58]

Why is this views-only?

[Finnur, 2013/05/06 23:13:54]

Good question. This was something I discovered by the test I wrote for this CL.
If we don't reset this, then destroying the button will trigger us to try to
unregister this keybinding again and the FocusManager will DCHECK because the
keybinding isn't registered (naturally). That doesn't happen on other platforms
(as keybindings are handled differently on each platform).

   }
 }