Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1498983003: [es6] Set correct length for Reflect.get (should be 2, not 3). (Closed)

Created:
5 years ago by neis
Modified:
5 years ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Set correct length for Reflect.get (should be 2, not 3). R=rossberg BUG= Committed: https://crrev.com/eb9407c6f5cba57f91b3e3bab73c476b7253aac9 Cr-Commit-Position: refs/heads/master@{#32615}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/reflect.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
neis
5 years ago (2015-12-04 10:13:19 UTC) #1
rossberg
lgtm
5 years ago (2015-12-04 13:18:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498983003/1
5 years ago (2015-12-04 13:21:10 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-04 13:40:31 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-04 13:40:50 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/eb9407c6f5cba57f91b3e3bab73c476b7253aac9
Cr-Commit-Position: refs/heads/master@{#32615}

Powered by Google App Engine
This is Rietveld 408576698