Issue 1498963004: Move the `Match` class from core/regex.dart to core/pattern.dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1498963004: Move the `Match` class from core/regex.dart to core/pattern.dart (Closed)

Created:
5 years ago by sigurdm

Modified:
5 years ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Move the `Match` class from core/regex.dart to core/pattern.dart Match is defined without depending Rexeg, but the String class depends on it. As these are both included as parts in core.dart this should have no external visible impact. BUG= R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/fc868df0045d67de8fe5feb81264e839dd5a9b05

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -88 lines)			Patch
	M	sdk/lib/core/pattern.dart	View		1 chunk	+87 lines, -0 lines	0 comments	Download
	M	sdk/lib/core/regexp.dart	View		1 chunk	+0 lines, -88 lines	0 comments	Download

Total messages: 5 (2 generated)

sigurdm

5 years ago (2015-12-04 12:19:57 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fc868df0045d67de8fe5feb81264e839dd5a9b05 (presubmit successful).