Delete patch classes once they are applied

There are about 60 patch classes in the libraries. Running dart2js causes about 25 of them to be compiled and applied, so we get rid of 25 of 60 Class objects.

Committed: https://github.com/dart-lang/sdk/commit/0bbfe1e23be56aad4a62cf6f7fea95a0a1efbb78

[hausner, 2015-12-03 20:54:39]

Description was changed from

==========
wip


Delete patch classes once applied

BUG=
==========

to

==========

==========

[hausner, 2015-12-03 21:05:24]

Description was changed from

==========

==========

to

==========
There are about 60 patch classes in the libraries. Running dart2js causes about
25 of them to be compiled and applied, so we get rid of 25 of 60 Class objects.
==========

[hausner, 2015-12-03 21:05:24]

hausner@google.com changed reviewers:
+ iposva@google.com

[hausner, 2015-12-04 01:44:40]

Added change: keep scripts of deleted patch classes.

[hausner, 2015-12-04 21:11:39]

Description was changed from

==========
There are about 60 patch classes in the libraries. Running dart2js causes about
25 of them to be compiled and applied, so we get rid of 25 of 60 Class objects.
==========

to

==========
There are about 60 patch classes in the libraries. Running dart2js causes about
25 of them to be compiled and applied, so we get rid of 25 of 60 Class objects.

Committed:
https://github.com/dart-lang/sdk/commit/0bbfe1e23be56aad4a62cf6f7fea95a0a1efbb78
==========

[hausner, 2015-12-04 21:11:40]

Committed patchset #5 (id:80001) manually as
0bbfe1e23be56aad4a62cf6f7fea95a0a1efbb78 (presubmit successful).

[hausner, 2015-12-04 21:53:06]

We discussed the change in person. I'll address any additional feedback in a
follow-on CL.

TBR=iposva

[Ivan Posva, 2015-12-08 09:11:14]

LGTMwC -ip

https://codereview.chromium.org/1498933002/diff/80001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1498933002/diff/80001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:9375: const Script& patch_script =
Script::Handle(pc.script());
Why is this not just
Script::Handle(cls.script());
?

https://codereview.chromium.org/1498933002/diff/80001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:9819: owner_script ^= Script::Cast(entry).raw();
Why is the ^= operator needed here?

[hausner, 2015-12-08 17:00:15]

Thanks for taking a good look I will include the changes in my next CL.

https://codereview.chromium.org/1498933002/diff/80001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1498933002/diff/80001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:9375: const Script& patch_script =
Script::Handle(pc.script());
On 2015/12/08 09:11:14, Ivan Posva wrote:
> Why is this not just
> Script::Handle(cls.script());
> ?

D'uh! I changed this code a few times and apparently didn't see the forest for
the trees anymore.

https://codereview.chromium.org/1498933002/diff/80001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:9819: owner_script ^= Script::Cast(entry).raw();
On 2015/12/08 09:11:14, Ivan Posva wrote:
> Why is the ^= operator needed here?

Good catch. Will remove.