Don't reset touch-action zoom state at scrollers

Don't reset touch-action zoom state at scrollers

This ensures that when a page disables double-tap zoom (eg. via
touch-action: manipulation) and hence the click delay, it stays
disabled even when tapping inside a scroller or iframe.

See https://github.com/w3c/pointerevents/issues/19 for details.

Also removes 'toCoreFrame' declaration which has no implementation
anywhere.  I needed this from my test but discovered the common
pattern was to just invoke the toImplBase method directly.

BUG=529295
Committed: https://crrev.com/41596bf935a7e28617a668f90f53590e357bc50a
Cr-Commit-Position: refs/heads/master@{#363310}

[Rick Byers, 2015-12-04 15:18:10]

Description was changed from

==========
Don't reset touch-action zoom state at scrollers

This ensures that when a page disables double-tap zoom (eg. via
touch-action: manipulation) and hence the click delay, it stays
disabled even when tapping inside a scroller or iframe.

See https://github.com/w3c/pointerevents/issues/19 for details.

BUG=529295
==========

to

==========
Don't reset touch-action zoom state at scrollers

This ensures that when a page disables double-tap zoom (eg. via
touch-action: manipulation) and hence the click delay, it stays
disabled even when tapping inside a scroller or iframe.

See https://github.com/w3c/pointerevents/issues/19 for details.

BUG=529295
==========

[Rick Byers, 2015-12-04 15:18:10]

rbyers@chromium.org changed reviewers:
+ dtapuska@chromium.org

[Rick Byers, 2015-12-04 15:18:18]

Dave, PTAL

[dtapuska, 2015-12-04 16:08:06]

https://codereview.chromium.org/1498923004/diff/1/third_party/WebKit/public/w...
File third_party/WebKit/public/web/WebFrame.h (left):

https://codereview.chromium.org/1498923004/diff/1/third_party/WebKit/public/w...
third_party/WebKit/public/web/WebFrame.h:748: Frame* toCoreFrame(const
WebFrame*);
Its not clear to me why this is being removed in this CL

[Rick Byers, 2015-12-04 16:28:02]

Description was changed from

==========
Don't reset touch-action zoom state at scrollers

This ensures that when a page disables double-tap zoom (eg. via
touch-action: manipulation) and hence the click delay, it stays
disabled even when tapping inside a scroller or iframe.

See https://github.com/w3c/pointerevents/issues/19 for details.

BUG=529295
==========

to

==========
Don't reset touch-action zoom state at scrollers

This ensures that when a page disables double-tap zoom (eg. via
touch-action: manipulation) and hence the click delay, it stays
disabled even when tapping inside a scroller or iframe.

See https://github.com/w3c/pointerevents/issues/19 for details.

Also removes 'toCoreFrame' declaration which has no implementation
anywhere.  I needed this from my test but discovered the common
pattern was to just invoke the toImplBase method directly.

BUG=529295
==========

[Rick Byers, 2015-12-04 16:28:11]

https://codereview.chromium.org/1498923004/diff/1/third_party/WebKit/public/w...
File third_party/WebKit/public/web/WebFrame.h (left):

https://codereview.chromium.org/1498923004/diff/1/third_party/WebKit/public/w...
third_party/WebKit/public/web/WebFrame.h:748: Frame* toCoreFrame(const
WebFrame*);
On 2015/12/04 16:08:05, dtapuska wrote:
> Its not clear to me why this is being removed in this CL

Oh right, sorry.  I went to use this API in my test and found there isn't any
implementation of it anywhere (just a couple similarly named methods inside
anonymous namespaces).  Mostly tests just inline the logic.  So to avoid someone
else being confused by the same thing I removed the dangling declaration.  I
could put it in a separate CL if you prefer, but that seemed like overkill to
me.  Updated CL description to include this.

[dtapuska, 2015-12-04 16:36:07]

On 2015/12/04 16:28:11, Rick Byers wrote:
>
https://codereview.chromium.org/1498923004/diff/1/third_party/WebKit/public/w...
> File third_party/WebKit/public/web/WebFrame.h (left):
> 
>
https://codereview.chromium.org/1498923004/diff/1/third_party/WebKit/public/w...
> third_party/WebKit/public/web/WebFrame.h:748: Frame* toCoreFrame(const
> WebFrame*);
> On 2015/12/04 16:08:05, dtapuska wrote:
> > Its not clear to me why this is being removed in this CL
> 
> Oh right, sorry.  I went to use this API in my test and found there isn't any
> implementation of it anywhere (just a couple similarly named methods inside
> anonymous namespaces).  Mostly tests just inline the logic.  So to avoid
someone
> else being confused by the same thing I removed the dangling declaration.  I
> could put it in a separate CL if you prefer, but that seemed like overkill to
> me.  Updated CL description to include this.

lgtm

[Rick Byers, 2015-12-04 22:08:19]

The CQ bit was checked by rbyers@chromium.org

[commit-bot: I haz the power, 2015-12-04 22:09:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1498923004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1498923004/1

[commit-bot: I haz the power, 2015-12-04 22:39:25]

Description was changed from

==========
Don't reset touch-action zoom state at scrollers

This ensures that when a page disables double-tap zoom (eg. via
touch-action: manipulation) and hence the click delay, it stays
disabled even when tapping inside a scroller or iframe.

See https://github.com/w3c/pointerevents/issues/19 for details.

Also removes 'toCoreFrame' declaration which has no implementation
anywhere.  I needed this from my test but discovered the common
pattern was to just invoke the toImplBase method directly.

BUG=529295
==========

to

==========
Don't reset touch-action zoom state at scrollers

This ensures that when a page disables double-tap zoom (eg. via
touch-action: manipulation) and hence the click delay, it stays
disabled even when tapping inside a scroller or iframe.

See https://github.com/w3c/pointerevents/issues/19 for details.

Also removes 'toCoreFrame' declaration which has no implementation
anywhere.  I needed this from my test but discovered the common
pattern was to just invoke the toImplBase method directly.

BUG=529295
==========

[commit-bot: I haz the power, 2015-12-04 22:39:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-04 23:07:45]

Description was changed from

==========
Don't reset touch-action zoom state at scrollers

This ensures that when a page disables double-tap zoom (eg. via
touch-action: manipulation) and hence the click delay, it stays
disabled even when tapping inside a scroller or iframe.

See https://github.com/w3c/pointerevents/issues/19 for details.

Also removes 'toCoreFrame' declaration which has no implementation
anywhere.  I needed this from my test but discovered the common
pattern was to just invoke the toImplBase method directly.

BUG=529295
==========

to

==========
Don't reset touch-action zoom state at scrollers

This ensures that when a page disables double-tap zoom (eg. via
touch-action: manipulation) and hence the click delay, it stays
disabled even when tapping inside a scroller or iframe.

See https://github.com/w3c/pointerevents/issues/19 for details.

Also removes 'toCoreFrame' declaration which has no implementation
anywhere.  I needed this from my test but discovered the common
pattern was to just invoke the toImplBase method directly.

BUG=529295

Committed: https://crrev.com/41596bf935a7e28617a668f90f53590e357bc50a
Cr-Commit-Position: refs/heads/master@{#363310}
==========

[commit-bot: I haz the power, 2015-12-04 23:07:46]

Patchset 1 (id:??) landed as
https://crrev.com/41596bf935a7e28617a668f90f53590e357bc50a
Cr-Commit-Position: refs/heads/master@{#363310}