src/codec/SkBmpRLECodec.h - Issue 1498923002: Fix overflow caught by ASAN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codec/SkBmpRLECodec.h

Issue 1498923002: Fix overflow caught by ASAN. (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: Refactor; remove SkBmpCodec::computeNumColors. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codec/SkBmpRLECodec.h

diff --git a/src/codec/SkBmpRLECodec.h b/src/codec/SkBmpRLECodec.h

index fcf910d8e5e7b74a4f6f4a536d561f1a485db3ca..df2a97d84502010a0c86efc5940466f9aba16082 100644

--- a/src/codec/SkBmpRLECodec.h

+++ b/src/codec/SkBmpRLECodec.h

@@ -90,6 +90,7 @@ private:

SkSampler* getSampler(bool createIfNecessary) override;

SkAutoTUnref<SkColorTable> fColorTable; // owned

+ // fNumColors is the number specified in the header, or 0 if not present in the header.

const uint32_t fNumColors;

const uint32_t fBytesPerColor;

const uint32_t fOffset;