DescriptionFix sketchy User Manager code :(
This fixes two things:
- the callbacks in UserManagerScreenHandler relied on SwitchToProfile
being asynchronous, or else they would destroy UserManagerScreenHandler
and then try to return to the function which would by then be gone.
- the BrowserList observer used by SwitchToProfile that waited to see
when a new browser window was open would sometimes go out of scope (because
it was a local variable) and clean itself up, not getting to see the new
browser being opened, and therefore never running the callback.
The observable effect was that unlocking a profile would keep the user
manager open (as noone told it to hide)
This probably explains the weird flakiness observed in
https://codereview.chromium.org/129333002/
BUG=NONE
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249858
Patch Set 1 #
Total comments: 10
Patch Set 2 : 'rebase' #Patch Set 3 : moar better comments #
Total comments: 6
Patch Set 4 : rebase #Patch Set 5 : alexei nits #Patch Set 6 : fix compile #
Messages
Total messages: 9 (0 generated)
|