Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 149883004: Fix sketchy User Manager code :( (Closed)

Created:
6 years, 10 months ago by noms (inactive)
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix sketchy User Manager code :( This fixes two things: - the callbacks in UserManagerScreenHandler relied on SwitchToProfile being asynchronous, or else they would destroy UserManagerScreenHandler and then try to return to the function which would by then be gone. - the BrowserList observer used by SwitchToProfile that waited to see when a new browser window was open would sometimes go out of scope (because it was a local variable) and clean itself up, not getting to see the new browser being opened, and therefore never running the callback. The observable effect was that unlocking a profile would keep the user manager open (as noone told it to hide) This probably explains the weird flakiness observed in https://codereview.chromium.org/129333002/ BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249858

Patch Set 1 #

Total comments: 10

Patch Set 2 : 'rebase' #

Patch Set 3 : moar better comments #

Total comments: 6

Patch Set 4 : rebase #

Patch Set 5 : alexei nits #

Patch Set 6 : fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -16 lines) Patch
M chrome/browser/profiles/profile_window.cc View 1 2 3 4 5 2 chunks +25 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/signin/user_manager_screen_handler.cc View 1 2 3 4 5 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
noms (inactive)
6 years, 10 months ago (2014-02-06 21:38:22 UTC) #1
Alexei Svitkine (slow)
https://codereview.chromium.org/149883004/diff/1/chrome/browser/profiles/profile_window.cc File chrome/browser/profiles/profile_window.cc (right): https://codereview.chromium.org/149883004/diff/1/chrome/browser/profiles/profile_window.cc#newcode43 chrome/browser/profiles/profile_window.cc:43: virtual void OnBrowserAdded(Browser* browser) OVERRIDE { I think this ...
6 years, 10 months ago (2014-02-06 22:02:11 UTC) #2
noms (inactive)
https://codereview.chromium.org/149883004/diff/1/chrome/browser/profiles/profile_window.cc File chrome/browser/profiles/profile_window.cc (right): https://codereview.chromium.org/149883004/diff/1/chrome/browser/profiles/profile_window.cc#newcode43 chrome/browser/profiles/profile_window.cc:43: virtual void OnBrowserAdded(Browser* browser) OVERRIDE { On 2014/02/06 22:02:12, ...
6 years, 10 months ago (2014-02-06 22:51:34 UTC) #3
Alexei Svitkine (slow)
LGTM with some final nits. Also, all your bots are red. https://codereview.chromium.org/149883004/diff/120001/chrome/browser/profiles/profile_window.cc File chrome/browser/profiles/profile_window.cc (right): ...
6 years, 10 months ago (2014-02-07 15:44:42 UTC) #4
noms (inactive)
https://codereview.chromium.org/149883004/diff/120001/chrome/browser/profiles/profile_window.cc File chrome/browser/profiles/profile_window.cc (right): https://codereview.chromium.org/149883004/diff/120001/chrome/browser/profiles/profile_window.cc#newcode30 chrome/browser/profiles/profile_window.cc:30: // Handles running a callback when a new Browser ...
6 years, 10 months ago (2014-02-07 16:30:58 UTC) #5
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 10 months ago (2014-02-07 18:19:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/149883004/260001
6 years, 10 months ago (2014-02-07 18:20:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/149883004/260001
6 years, 10 months ago (2014-02-07 22:12:46 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-07 23:55:33 UTC) #9
Message was sent while issue was closed.
Change committed as 249858

Powered by Google App Engine
This is Rietveld 408576698