Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1498823002: Sync the Storage API with the spec (Closed)

Created:
5 years ago by philipj_slow
Modified:
5 years ago
Reviewers:
jsbell
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sync the Storage API with the spec https://html.spec.whatwg.org/multipage/webstorage.html The only change to the generated code is the data->value rename. BUG=460722 R=jsbell@chromium.org Committed: https://crrev.com/cee4df3805002dd8d648b5ad2db7df2c3e35b4ec Cr-Commit-Position: refs/heads/master@{#362999}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -14 lines) Patch
M third_party/WebKit/Source/modules/storage/Storage.idl View 1 chunk +14 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/storage/StorageEvent.idl View 3 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/storage/StorageEventInit.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498823002/1
5 years ago (2015-12-03 11:17:00 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-03 12:31:25 UTC) #4
philipj_slow
PTAL. I'd like to remove initStorageEvent, so found myself poking around in these files.
5 years ago (2015-12-03 12:41:18 UTC) #5
jsbell
lgtm
5 years ago (2015-12-03 17:08:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498823002/1
5 years ago (2015-12-03 17:09:24 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 17:15:46 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-03 17:16:49 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cee4df3805002dd8d648b5ad2db7df2c3e35b4ec
Cr-Commit-Position: refs/heads/master@{#362999}

Powered by Google App Engine
This is Rietveld 408576698