Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1498813002: [TTS] Add command to open Touch to search preferences. (Closed)

Created:
5 years ago by Olivier
Modified:
5 years ago
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[TTS] Add command to open Touch to search preferences. BUG=503585 Committed: https://crrev.com/95e2926b29b8d8c7390ea64b73e98f978b6ea0ff Cr-Commit-Position: refs/heads/master@{#362969}

Patch Set 1 #

Total comments: 2

Patch Set 2 : 40919 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ios/chrome/browser/ui/commands/ios_command_ids.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Olivier
Add command to open TTS settings. Please note that format is not what git cl ...
5 years ago (2015-12-03 12:37:05 UTC) #2
droger
lgtm I think there is a typo in the CL title. https://codereview.chromium.org/1498813002/diff/1/ios/chrome/browser/ui/commands/ios_command_ids.h File ios/chrome/browser/ui/commands/ios_command_ids.h (right): ...
5 years ago (2015-12-03 13:05:00 UTC) #3
marq (ping after 24h)
lgtm
5 years ago (2015-12-03 13:07:54 UTC) #4
Olivier
Thanks. Done https://codereview.chromium.org/1498813002/diff/1/ios/chrome/browser/ui/commands/ios_command_ids.h File ios/chrome/browser/ui/commands/ios_command_ids.h (right): https://codereview.chromium.org/1498813002/diff/1/ios/chrome/browser/ui/commands/ios_command_ids.h#newcode60 ios/chrome/browser/ui/commands/ios_command_ids.h:60: #define IDC_SHOW_CONTEXTUAL_SEARCH_SETTINGS 40949 On 2015/12/03 13:05:00, droger ...
5 years ago (2015-12-03 13:09:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498813002/20001
5 years ago (2015-12-03 13:10:22 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-03 13:21:20 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-03 13:22:20 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/95e2926b29b8d8c7390ea64b73e98f978b6ea0ff
Cr-Commit-Position: refs/heads/master@{#362969}

Powered by Google App Engine
This is Rietveld 408576698