Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 14988010: Performance fix for Vista+ where non-IME input is reported as IME (Closed)

Created:
7 years, 7 months ago by kochi
Modified:
7 years, 7 months ago
CC:
chromium-reviews, nona+watch_chromium.org, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@imeapi
Visibility:
Public.

Description

On Windows Vista and its follow-ons, ImmIsIME() returns always true, thus non-IME input languages were classified as IME. This caused extra traffic of IPCs. This CL uses ImmGetFileName() to check if a given keyboard layout has any associated IME or not. BUG=241342 TEST=manually check if IME works properly on Vista+ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201035

Patch Set 1 : . #

Patch Set 2 : improve comments. #

Total comments: 2

Patch Set 3 : use base::win::ScopedComPtr rather than CComPtr. #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M ui/base/win/ime_input.cc View 1 2 3 2 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
kochi
Hi Yukawa-san, Could you review this? Thanks,
7 years, 7 months ago (2013-05-16 07:08:11 UTC) #1
Yohei Yukawa
https://codereview.chromium.org/14988010/diff/8001/ui/base/win/ime_input.cc File ui/base/win/ime_input.cc (right): https://codereview.chromium.org/14988010/diff/8001/ui/base/win/ime_input.cc#newcode140 ui/base/win/ime_input.cc:140: CComPtr<ITfInputProcessorProfileMgr> prof_mgr; We prefer to use our own scoped ...
7 years, 7 months ago (2013-05-16 08:55:02 UTC) #2
kochi
Thanks for the review! Nona-san, once I get LGTM from Yukawa-san, could you OWNERS review? ...
7 years, 7 months ago (2013-05-16 10:29:31 UTC) #3
Yohei Yukawa
lgtm
7 years, 7 months ago (2013-05-16 10:35:15 UTC) #4
Seigo Nonaka
lgtm but I'm not an owner of this file. Please send to ui/ owners.
7 years, 7 months ago (2013-05-17 03:58:22 UTC) #5
kochi
Hi Scott, Could you take an OWNERS look? Thanks,
7 years, 7 months ago (2013-05-17 04:01:03 UTC) #6
sky
LGTM
7 years, 7 months ago (2013-05-17 15:43:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kochi@chromium.org/14988010/14001
7 years, 7 months ago (2013-05-19 15:30:55 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=150797
7 years, 7 months ago (2013-05-19 16:57:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kochi@chromium.org/14988010/34001
7 years, 7 months ago (2013-05-20 02:26:17 UTC) #10
commit-bot: I haz the power
7 years, 7 months ago (2013-05-20 05:49:50 UTC) #11
Message was sent while issue was closed.
Change committed as 201035

Powered by Google App Engine
This is Rietveld 408576698