Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: src/incremental-marking.h

Issue 14988004: Revert fix incremental marking speed accelleration and start incremental marking when old space is … (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/incremental-marking.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 static const intptr_t kInitialMarkingSpeed = 1; 103 static const intptr_t kInitialMarkingSpeed = 1;
104 // But if we are promoting a lot of data we need to mark faster to keep up 104 // But if we are promoting a lot of data we need to mark faster to keep up
105 // with the data that is entering the old space through promotion. 105 // with the data that is entering the old space through promotion.
106 static const intptr_t kFastMarking = 3; 106 static const intptr_t kFastMarking = 3;
107 // After this many steps we increase the marking/allocating factor. 107 // After this many steps we increase the marking/allocating factor.
108 static const intptr_t kMarkingSpeedAccellerationInterval = 1024; 108 static const intptr_t kMarkingSpeedAccellerationInterval = 1024;
109 // This is how much we increase the marking/allocating factor by. 109 // This is how much we increase the marking/allocating factor by.
110 static const intptr_t kMarkingSpeedAccelleration = 2; 110 static const intptr_t kMarkingSpeedAccelleration = 2;
111 static const intptr_t kMaxMarkingSpeed = 1000; 111 static const intptr_t kMaxMarkingSpeed = 1000;
112 112
113 void OldSpaceStep(intptr_t allocated); 113 void OldSpaceStep(intptr_t allocated) {
114 Step(allocated * kFastMarking / kInitialMarkingSpeed,
115 GC_VIA_STACK_GUARD);
116 }
114 117
115 void Step(intptr_t allocated, CompletionAction action); 118 void Step(intptr_t allocated, CompletionAction action);
116 119
117 inline void RestartIfNotMarking() { 120 inline void RestartIfNotMarking() {
118 if (state_ == COMPLETE) { 121 if (state_ == COMPLETE) {
119 state_ = MARKING; 122 state_ = MARKING;
120 if (FLAG_trace_incremental_marking) { 123 if (FLAG_trace_incremental_marking) {
121 PrintF("[IncrementalMarking] Restarting (new grey objects)\n"); 124 PrintF("[IncrementalMarking] Restarting (new grey objects)\n");
122 } 125 }
123 } 126 }
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
273 intptr_t write_barriers_invoked_since_last_step_; 276 intptr_t write_barriers_invoked_since_last_step_;
274 277
275 int no_marking_scope_depth_; 278 int no_marking_scope_depth_;
276 279
277 DISALLOW_IMPLICIT_CONSTRUCTORS(IncrementalMarking); 280 DISALLOW_IMPLICIT_CONSTRUCTORS(IncrementalMarking);
278 }; 281 };
279 282
280 } } // namespace v8::internal 283 } } // namespace v8::internal
281 284
282 #endif // V8_INCREMENTAL_MARKING_H_ 285 #endif // V8_INCREMENTAL_MARKING_H_
OLDNEW
« no previous file with comments | « no previous file | src/incremental-marking.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698