Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: net/cookies/cookie_store_unittest.h

Issue 1498793002: [iOS] Disable parts of TestNonDottedAndTLD cookie store unittest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cookies/cookie_store_unittest.h
diff --git a/net/cookies/cookie_store_unittest.h b/net/cookies/cookie_store_unittest.h
index bb8728c363553b8293dd69cb3a3e2013cbdfe9c2..df350b3978889e9398713eea606322827679fff8 100644
--- a/net/cookies/cookie_store_unittest.h
+++ b/net/cookies/cookie_store_unittest.h
@@ -528,7 +528,7 @@ TYPED_TEST_P(CookieStoreTest, TestNonDottedAndTLD) {
}
}
- {
+ if (TypeParam::supports_non_dotted_domains) {
// Exact matches between the domain attribute and the host are treated as
// host cookies, not domain cookies.
scoped_refptr<CookieStore> cs(this->GetCookieStore());
@@ -541,10 +541,8 @@ TYPED_TEST_P(CookieStoreTest, TestNonDottedAndTLD) {
this->MatchCookieLines(
std::string(),
this->GetCookies(cs.get(), GURL("http://hopefully-no-cookies.com/")));
- if (TypeParam::supports_non_dotted_domains) {
- this->MatchCookieLines(std::string(),
- this->GetCookies(cs.get(), GURL("http://.com/")));
- }
+ this->MatchCookieLines(std::string(),
+ this->GetCookies(cs.get(), GURL("http://.com/")));
}
{
@@ -597,7 +595,7 @@ TYPED_TEST_P(CookieStoreTest, TestNonDottedAndTLD) {
this->MatchCookieLines("a=1", this->GetCookies(cs.get(), url));
}
- {
+ if (TypeParam::supports_non_dotted_domains) {
// Exact matches between the domain attribute and an intranet host are
// treated as host cookies, not domain cookies.
scoped_refptr<CookieStore> cs(this->GetCookieStore());
@@ -610,10 +608,8 @@ TYPED_TEST_P(CookieStoreTest, TestNonDottedAndTLD) {
this->MatchCookieLines(
std::string(),
this->GetCookies(cs.get(), GURL("http://hopefully-no-cookies.b/")));
- if (TypeParam::supports_non_dotted_domains) {
- this->MatchCookieLines(std::string(),
- this->GetCookies(cs.get(), GURL("http://.b/")));
- }
+ this->MatchCookieLines(std::string(),
+ this->GetCookies(cs.get(), GURL("http://.b/")));
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698